-
Notifications
You must be signed in to change notification settings - Fork 4k
More misc st.experimental_connection renames #6457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vdonato
merged 4 commits into
feature/st.experimental_connection
from
vdonato/misc-changes-2
Apr 11, 2023
Merged
More misc st.experimental_connection renames #6457
vdonato
merged 4 commits into
feature/st.experimental_connection
from
vdonato/misc-changes-2
Apr 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f44239f to
044e1ff
Compare
cadef87 to
b17a92f
Compare
sfc-gh-kjavadyan
approved these changes
Apr 11, 2023
97215a9 to
9fd4d5a
Compare
vdonato
added a commit
that referenced
this pull request
Apr 11, 2023
* Rename connection_class -> type * Rename read_sql -> query for SQL and Snowpark connections * Plumb a few arguments through SQL.query explicitly * Get rid of now stale TODO
vdonato
added a commit
that referenced
this pull request
Apr 15, 2023
* Rename connection_class -> type * Rename read_sql -> query for SQL and Snowpark connections * Plumb a few arguments through SQL.query explicitly * Get rid of now stale TODO
vdonato
added a commit
that referenced
this pull request
Apr 17, 2023
* Rename connection_class -> type * Rename read_sql -> query for SQL and Snowpark connections * Plumb a few arguments through SQL.query explicitly * Get rid of now stale TODO
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
* Rename connection_class -> type * Rename read_sql -> query for SQL and Snowpark connections * Plumb a few arguments through SQL.query explicitly * Get rid of now stale TODO
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Rename connection_class -> type * Rename read_sql -> query for SQL and Snowpark connections * Plumb a few arguments through SQL.query explicitly * Get rid of now stale TODO
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Rename connection_class -> type * Rename read_sql -> query for SQL and Snowpark connections * Plumb a few arguments through SQL.query explicitly * Get rid of now stale TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: It's easier to review these changes commit-wise.
📚 Context
This PR batches some misc tweaks to
st.experimental_connectionthat are all small enough to notwarrant their own PRs:
SQLandSnowparkconnections toquerySQL.querytopd.read_sql(so that intellisense suggests them)connection_classargument totype.