Skip to content

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented Apr 7, 2023

Note: It's easier to review these changes commit-wise.

📚 Context

This PR batches some misc tweaks to st.experimental_connection that are all small enough to not
warrant their own PRs:

  • Change the read helper method name for the SQL and Snowpark connections to query
  • Plumb a few params through SQL.query to pd.read_sql (so that intellisense suggests them)
  • Changed the name of the connection_class argument to type.

@vdonato vdonato added the security-assessment-completed Security assessment has been completed for PR label Apr 7, 2023
@vdonato vdonato requested a review from kajarenc April 7, 2023 23:12
@vdonato vdonato force-pushed the feature/st.experimental_connection branch from f44239f to 044e1ff Compare April 10, 2023 21:08
@vdonato vdonato force-pushed the vdonato/misc-changes-2 branch from cadef87 to b17a92f Compare April 10, 2023 21:09
@vdonato vdonato changed the title More misc st.experimental_connection changes More misc st.experimental_connection renames Apr 11, 2023
@vdonato vdonato force-pushed the vdonato/misc-changes-2 branch from 97215a9 to 9fd4d5a Compare April 11, 2023 18:24
@vdonato vdonato merged this pull request into feature/st.experimental_connection Apr 11, 2023
@vdonato vdonato deleted the vdonato/misc-changes-2 branch April 11, 2023 19:06
vdonato added a commit that referenced this pull request Apr 11, 2023
* Rename connection_class -> type

* Rename read_sql -> query for SQL and Snowpark connections

* Plumb a few arguments through SQL.query explicitly

* Get rid of now stale TODO
vdonato added a commit that referenced this pull request Apr 15, 2023
* Rename connection_class -> type

* Rename read_sql -> query for SQL and Snowpark connections

* Plumb a few arguments through SQL.query explicitly

* Get rid of now stale TODO
vdonato added a commit that referenced this pull request Apr 17, 2023
* Rename connection_class -> type

* Rename read_sql -> query for SQL and Snowpark connections

* Plumb a few arguments through SQL.query explicitly

* Get rid of now stale TODO
vdonato added a commit that referenced this pull request Apr 19, 2023
* Rename connection_class -> type

* Rename read_sql -> query for SQL and Snowpark connections

* Plumb a few arguments through SQL.query explicitly

* Get rid of now stale TODO
vdonato added a commit that referenced this pull request Apr 20, 2023
* Rename connection_class -> type

* Rename read_sql -> query for SQL and Snowpark connections

* Plumb a few arguments through SQL.query explicitly

* Get rid of now stale TODO
vdonato added a commit that referenced this pull request Apr 21, 2023
* Rename connection_class -> type

* Rename read_sql -> query for SQL and Snowpark connections

* Plumb a few arguments through SQL.query explicitly

* Get rid of now stale TODO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants