Allow st.experimental_connection callers to set a name via envvar #6446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Btw @kajarenc, I think we have the go-ahead on wanting to do this from product, so this is now ready for code review |
f44239f to
044e1ff
Compare
a8a5b7d to
7e24725
Compare
kajarenc
reviewed
Apr 11, 2023
| literal as the connection_class. | ||
| * Plugging your own ConnectionClass into st.experimental_connection. | ||
| """ | ||
| USE_ENV_PREFIX = "env:" |
Collaborator
There was a problem hiding this comment.
how does this should correlate with streamlit-specific config options with the STREAMLIT_ prefix?
Collaborator
Author
There was a problem hiding this comment.
I don't think there are any explicit interactions we need to design for. In theory, a user could choose to have their connection name set by env:STREAMLIT_*, but I don't see a reason anyone would want to do this since all the config options are for unrelated things
kajarenc
approved these changes
Apr 11, 2023
vdonato
added a commit
that referenced
this pull request
Apr 11, 2023
vdonato
added a commit
that referenced
this pull request
Apr 15, 2023
vdonato
added a commit
that referenced
this pull request
Apr 17, 2023
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This small feature allows users to be able to set the name of their connection in their
environment variables, then denote which environment variable to get the name from
by passing
env:<NAME_OF_ENVVAR>tost.experimental_connection.A similar pattern already exists within our config options set via command line flag or
config.toml.