Skip to content

Make slight improvement to missing requirement handling #6395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vdonato merged 1 commit into from
Mar 30, 2023
Merged

Make slight improvement to missing requirement handling #6395

vdonato merged 1 commit into from
Mar 30, 2023
+13 −15

Conversation

@vdonato
Copy link
Collaborator

@vdonato vdonato commented Mar 30, 2023

📚 Context

While manually testing the Snowpark first party connection, I realized that the import
can fail at multiple points when importing from a nested module.

🧪 Testing Done

  • Added/Updated unit tests

@vdonato vdonato added the security-assessment-completed Security assessment has been completed for PR label Mar 30, 2023
@vdonato vdonato requested a review from lukasmasuch March 30, 2023 00:33
lukasmasuch
lukasmasuch approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vdonato vdonato merged this pull request into feature/st.experimental_connection Mar 30, 2023
@vdonato vdonato deleted the vdonato/missing_dep_msg_tweaks branch March 30, 2023 23:53
vdonato added a commit that referenced this pull request Mar 31, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
c08f08a
vdonato added a commit that referenced this pull request Mar 31, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
157ffc8
vdonato added a commit that referenced this pull request Apr 4, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
53f1092
vdonato added a commit that referenced this pull request Apr 6, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
b05ba58
vdonato added a commit that referenced this pull request Apr 6, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
5a5a6c4
vdonato added a commit that referenced this pull request Apr 10, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
85711c1
vdonato added a commit that referenced this pull request Apr 11, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
89e1d8d
vdonato added a commit that referenced this pull request Apr 15, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
816489a
vdonato added a commit that referenced this pull request Apr 17, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
2fa06be
vdonato added a commit that referenced this pull request Apr 19, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
27a0e7e
vdonato added a commit that referenced this pull request Apr 20, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
da5833a
vdonato added a commit that referenced this pull request Apr 21, 2023
@vdonato
Make slight improvement to missing requirement handling (#6395)
83ae4dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch lukasmasuch approved these changes

Assignees

No one assigned

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vdonato @lukasmasuch