Add implementation of SQL connection #6381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c872658 to
98976a0
Compare
ea0e408 to
33b300e
Compare
98976a0 to
1cfede6
Compare
Contributor
There was a problem hiding this comment.
I still believe we need some way for additional secrets to be added as arguments in this call.
A good concrete example is BigQuery. I'd like to be able to configure my credentials_info in secrets.toml or provide a credentials_path and have them passed to create_engine().
Cite: https://github.com/googleapis/python-bigquery-sqlalchemy#authentication
Collaborator
Author
There was a problem hiding this comment.
Ack -- I'll address this when circling back to merging config options / params from various places for both this connector and the Snowpark one
33b300e to
151e36d
Compare
1cfede6 to
6245642
Compare
vdonato
added a commit
that referenced
this pull request
Mar 31, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Mar 31, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 4, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 6, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 6, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 10, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 11, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 15, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 17, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Add implementation of SQL connection * Use sqlalchemy.text for 2.0 compatibility * Add unit tests for SQL connection * Add autocommit kwarg to connection_factory overload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is being merged into
feature/st.experimental_connection.📚 Context
This PR adds an implementation for one of our first party connection classes: the
SQLconnection.The SQL connection is a simple wrapper around SQLAchemy that plays nicely with a developer's
secrets.tomlfile and thest.experimental_connectionfactory function.There are a few notable things missing from the
SQLconnection class for now. Notably,read_sqlmethod still need to be implemented.We need to add some unit tests for the class itself. This will be done in a later PR.