Reload the connection when its secrets section changes #6359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
reviewed
Mar 27, 2023
lukasmasuch
approved these changes
Mar 27, 2023
Collaborator
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 Just one thing to double-check related to the hashing of the secrets pickle.
vdonato
added a commit
that referenced
this pull request
Mar 27, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Mar 29, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Mar 31, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Mar 31, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 4, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 6, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 6, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 10, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 11, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 15, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 17, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 19, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 20, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
vdonato
added a commit
that referenced
this pull request
Apr 21, 2023
* Reload the connection when its secrets section changes * Use json instead of pickled dict to construct hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is going into
feature/st.experimental_connection.📚 Context
One nice thing we want to do with
st.experimental_connectionis to have it reset whenever itscorresponding section in
secrets.tomlchange, but do nothing in the case that an unrelatedsecret changes.
🧪 Testing Done