Enable no-else-return rule in ESLint #6205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdonato
approved these changes
Mar 2, 2023
9 tasks
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 9, 2023
* develop: Allow control of st.pyplot() width (streamlit#6067) `withMapboxToken`: add types (streamlit#6275) Add step parameter to st.time_input (streamlit#6071) Enable no-else-return rule in ESLint (streamlit#6205) Fix `make tstypecheck` (streamlit#6273)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 9, 2023
# By Kamil Breguła (2) and others # Via GitHub * develop: Allow control of st.pyplot() width (streamlit#6067) `withMapboxToken`: add types (streamlit#6275) Add step parameter to st.time_input (streamlit#6071) Enable no-else-return rule in ESLint (streamlit#6205) Fix `make tstypecheck` (streamlit#6273) # Conflicts: # frontend/src/hocs/withMapboxToken/withMapboxToken.test.tsx # frontend/src/hocs/withMapboxToken/withMapboxToken.tsx
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Discussion: #6174 (comment)
Please describe the project or issue background here
What kind of change does this PR introduce?
🧠 Description of Changes
Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.