Fix slider overlap values for ranges #5913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
reviewed
Jan 5, 2023
Comment on lines
99
to
101
| this.thumbValueAlignment( | ||
| this.thumbRef[i].current, | ||
| this.thumbValueRef[i].current |
Collaborator
There was a problem hiding this comment.
I don't believe this second call to this.thumbValueAlignment is necessary.
Did some console.log & manual testing to verify that the for loop iterates over both thumb value instances for the range, and removing does not change the alignment behavior.
Collaborator
Author
There was a problem hiding this comment.
🤦 Yep! you are right. I just removed it. Great catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
We fixed sliders to adjust the label if it appears outside of the screen, but it fails for ranges where there are two thumb values. This change allows for us to adjust.
What kind of change does this PR introduce?
🧠 Description of Changes
Revised:
Current:
🧪 Testing Done
🌐 References
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.