Singleton: ttl and max_entries support
#5821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajarenc
reviewed
Dec 7, 2022
| from typing import Any | ||
| from unittest.mock import MagicMock, Mock, mock_open, patch | ||
|
|
||
| from parameterized import parameterized |
Collaborator
There was a problem hiding this comment.
nit: looks like this import is unused now
Contributor
Author
There was a problem hiding this comment.
Oh whoops - I totally missed that and hit merge. I'll get it in an upcoming PR!
kajarenc
approved these changes
Dec 7, 2022
tconkling
added a commit
that referenced
this pull request
Dec 7, 2022
* develop: Singleton: `ttl` and `max_entries` support (#5821) Bump express from 4.17.1 to 4.18.2 in /frontend (#5823) Bump qs from 6.5.2 to 6.5.3 in /frontend (#5822) Bump decode-uri-component from 0.2.0 to 0.2.2 in /frontend (#5802) Improve st.experimental_memo exception on Snowpark/PySpark integration (#5791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ttlandmax_entriessupport to@st.experimental_singleton.This is primarily just copied from the existing support in
memo, which means thatsingletonnow uses acachetools.TTLCacheinstance for its storage.There are a few new common utilities and tests where appropriate.