Fix failing Cypress test (3), test(4) #5797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mayagbarnes
approved these changes
Dec 1, 2022
Collaborator
mayagbarnes
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @snehankekre 👍🏼
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Dec 1, 2022
* develop: Fix failing Cypress test (3), test(4) (streamlit#5797)
tconkling
added a commit
that referenced
this pull request
Dec 1, 2022
* develop: Fix failing Cypress test (3), test(4) (#5797)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Dec 1, 2022
# By Snehan Kekre (1) and Tim Conkling (1) # Via Tim Conkling (2) and GitHub (1) * feature/ReleaseCacheV2: deprecation_util: handle arbitrary name changes (streamlit#5795) Fix failing Cypress test (3), test(4) (streamlit#5797) # Conflicts: # lib/streamlit/deprecation_util.py # lib/tests/streamlit/deprecation_util_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Recent PRs are failing Cypress test (3) and test (4).
st_alert.spec.js. There's a diff inalert7-(dark|light).snap.png.st_arrow_dataframe_canvas_rendering.spec.js. There's a diff indata-grid-canvas-21-(dark|light).snap.pngIn both tests, there are visible differences in the appearance and pixels of rendered emojis:
What kind of change does this PR introduce?
🧠 Description of Changes
This PR updates the respective snapshots.
🧪 Testing Done