Use newer annotations features in caching modules #5738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnOctopus
commented
Nov 19, 2022
harahu
reviewed
Nov 23, 2022
Contributor
harahu
left a comment
There was a problem hiding this comment.
Am realizing I was starting to repeat myself quite a bit here, so it's probably better to summarize.
Basically, there's a few more generic types you can replace, like tuples and sets.
That being said, great effort. I think this is a good idea, unless you have runtime uses for type annotations, which I don't think you do.
Contributor
Author
|
Good catches, wrt |
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 29, 2022
* develop: Use newer annotations features in caching modules (streamlit#5738) Add links for workflow failure slack messages (streamlit#5772) Refactor AppSession to simplify improving reconnect behavior (streamlit#5782) Fixing component-template typecheck failure (streamlit#5780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
It came up that
from __future__ import annotationsallows us to use generic builtins, type union syntax, and lazy annotations, while still being compatible with 3.7. So let's start using them.What kind of change does this PR introduce?
🧠 Description of Changes
🧪 Testing Done