cache_utils.get_decorator_api_name util #5721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move CacheType out of cache_errors.py, since it's not intrinsically error-related - CacheType.value is no longer the public API name of the decorator it refers to. Instead, `get_decorator_api_name` implements this mapping explicitly.
vdonato
approved these changes
Nov 18, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 18, 2022
* develop: cache_utils.get_decorator_api_name util (streamlit#5721) Add blocking tests to release workflow (streamlit#5732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CacheType.valueis currently implicitly used to store the name of the public API that the CacheType refers to. (That is,CacheType.MEMOhas the value"experimental_memo".) This isn't documented anywhere, and it's not intuitive.This PR changes that:
CacheType.valueis now the stringified version of the enum name ("MEMO" and "SINGLETON" instead of "experimental_memo" and "experimental_singleton")get_decorator_api_name, returns the public API name for the given CacheType