Add mypy fixes #5662
Merged
Add mypy fixes #5662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-kbregula
approved these changes
Nov 8, 2022
lukasmasuch
reviewed
Nov 8, 2022
| Value: TypeAlias = Union["np.integer", "np.floating", float, str, None] | ||
| Delta: TypeAlias = Union[float, str, None] | ||
| Value: TypeAlias = Union["np.integer", "np.floating", float, int, str, None] | ||
| Delta: TypeAlias = Union[float, int, str, None] |
Collaborator
There was a problem hiding this comment.
nit: are we not supporting "np.integer", "np.floating", for Delta as well?
Contributor
Author
There was a problem hiding this comment.
Hm good point. I'll add those
Collaborator
There was a problem hiding this comment.
Hmm, looking at this a bit more, we actually do extra stuff for numpy values here:
streamlit/lib/streamlit/elements/metric.py
Line 143 in 69d2027
Contributor
Author
There was a problem hiding this comment.
Should we add that code and make it a function for reusability and add support for delta? I think Deltas and Values would almost surely likely use the same types.
Contributor
Author
There was a problem hiding this comment.
I have decided to make this a separate PR.
lukasmasuch
approved these changes
Nov 8, 2022
This reverts commit 69d2027.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 8, 2022
* develop: Add mypy fixes (streamlit#5662) Don't render stale st.snow and st.ballons elements (streamlit#5401)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 8, 2022
* develop: Add mypy fixes (streamlit#5662) Don't render stale st.snow and st.ballons elements (streamlit#5401) Fix unevaluated dataframe exception formatting (streamlit#5657) Update aboutDialog to check SessionInfo.isSet() before referring the instance (streamlit#5518) Replace assertEquals->assertEqual to silence deprecation warnings (streamlit#5648) Reworke AttrDict for st.secrets to explicitly disallow item and attribute assignment (streamlit#5621) Fix pydoc command for streamlit package (streamlit#5535) Temporarily have /st-allowed-message-origins double as a healthcheck (streamlit#5642) Fix Plotly Charts when exiting out of fullscreen (streamlit#5645) Flaky test e2e fixes (streamlit#5610)
kmcgrady
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
mypy is failing
Please describe the project or issue background here
What kind of change does this PR introduce?
🧠 Description of Changes
remove unnecessary mypy ignores and add ints for metric.py