-
Notifications
You must be signed in to change notification settings - Fork 4k
[polish] Replace Mic icon with MicNone icon in st.chat_input
#13553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ PR preview is ready!
|
SummaryThis PR makes a simple visual change to the Code QualityThe change is minimal and straightforward: import { Mic } from "@emotion-icons/material-outlined"Positive observations:
Design note: The codebase uses a mixed icon style strategy where different icon packages are used for different purposes. The Test CoverageExisting coverage is adequate:
Note: The visual snapshot tests will require baseline updates since the icon style is changing. This is expected and CI will flag the snapshots that need to be regenerated. The PR author should ensure snapshot baselines are updated as part of this PR. Backwards CompatibilityNo breaking changes. This is a purely visual change that:
Users may notice the microphone icon looks slightly different (outlined vs rounded), but this is a minor visual refinement that shouldn't impact any functionality. Security & RiskVery low risk. The change:
Recommendations
VerdictAPPROVED: This is a low-risk, purely visual change that improves consistency by aligning the This is an automated AI review. Please verify the feedback and use your judgment. |
68a33de to
d3e05b7
Compare
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0000%
✅ Coverage change is within normal range. |
090af58 to
5a74fd6
Compare
st.chat_input
SummaryThis PR makes a simple visual change to the Changes:
Code QualityThe code changes are clean and minimal: import { MicNone } from "@emotion-icons/material-outlined"<Icon
content={MicNone}
size="xl"
color="inherit"
/>Positive observations:
No issues identified. Test CoverageThe test coverage is appropriate for this change:
Backwards Compatibility✅ Fully backwards compatible
Security & Risk✅ No security concerns
Risk Assessment: Very Low
RecommendationsNo changes required. The PR is well-executed:
VerdictAPPROVED: This is a clean, focused visual polish change that replaces the filled microphone icon with an outlined variant. The implementation is correct, uses existing dependencies, and has appropriate snapshot test coverage across browsers and themes. This is an automated AI review. Please verify the feedback and use your judgment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the microphone icon in the ChatInput component from a filled Mic icon to an outlined MicNone icon, improving visual consistency with the application's design language.
Changes:
- Replaced the microphone icon import from
@emotion-icons/material-rounded(Mic) to@emotion-icons/material-outlined(MicNone) - Updated the icon reference in the component JSX
- Regenerated snapshot tests for all browser/theme combinations to reflect the new icon appearance
Reviewed changes
Copilot reviewed 1 out of 33 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/lib/src/components/widgets/ChatInput/ChatInput.tsx | Updated icon import and usage from filled Mic to outlined MicNone |
| e2e_playwright/snapshots/linux/st_chat_input_test/*.png | Updated visual regression test snapshots across all browsers (webkit, firefox, chromium) and themes (light, dark) |

Describe your changes
Changed the microphone icon in the ChatInput component from the filled
Micicon to the outlinedMicNoneicon, updating the import from@emotion-icons/material-roundedto@emotion-icons/material-outlined.Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.