Skip to content

Conversation

@sfc-gh-nbellante
Copy link
Contributor

@sfc-gh-nbellante sfc-gh-nbellante commented Jan 7, 2026

Describe your changes

Updated the border radius of file upload icons in the chat input component from theme.radii.md to theme.radii.default to match the designs in Figma.

Screenshot or video (only for visual changes)

The PR updates all snapshot images for file chips in the chat input component across different browsers (Chromium, Firefox, and WebKit) and themes (light and dark).

Testing Plan

  • No additional tests are needed as this is a visual change only
  • The existing E2E tests have been updated with new snapshots that reflect the border radius change
  • The visual changes have been verified across all browsers and themes

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Jan 7, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-13532/streamlit-1.52.2-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-13532.streamlit.app (☁️ Deploy here if not accessible)

Copy link
Contributor Author

sfc-gh-nbellante commented Jan 7, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

📉 Frontend coverage change detected

The frontend unit test (vitest) coverage has decreased by 0.0000%

  • Current PR: 86.5600% (12810 lines, 1721 missed)
  • Latest develop: 86.5600% (12810 lines, 1721 missed)

✅ Coverage change is within normal range.

📊 View detailed coverage comparison

@sfc-gh-nbellante sfc-gh-nbellante force-pushed the fixit/file-chip-icon-border-radius branch from 5c4ff72 to 7992f54 Compare January 8, 2026 17:18
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the fixit/file-chip-icon-border-radius branch 2 times, most recently from 114c830 to cc7e6e4 Compare January 8, 2026 20:56
@sfc-gh-nbellante sfc-gh-nbellante marked this pull request as ready for review January 8, 2026 20:56
Copilot AI review requested due to automatic review settings January 8, 2026 20:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the border radius of the file chip icon container in the chat input component to match the Figma design specification. The change modifies the border radius from theme.radii.md to theme.radii.default.

Key Changes

  • Updated border radius property in the file chip icon styled component
  • Regenerated all E2E test snapshots to reflect the visual change

Reviewed changes

Copilot reviewed 1 out of 49 changed files in this pull request and generated no comments.

File Description
frontend/lib/src/components/widgets/ChatInput/fileUpload/styled-components.ts Changed border radius from theme.radii.md to theme.radii.default for the file icon container
e2e_playwright/__snapshots__/linux/st_chat_input_test/*.png Updated all visual regression test snapshots across browsers and themes to reflect the border radius change

@sfc-gh-nbellante sfc-gh-nbellante force-pushed the fixit/file-chip-icon-border-radius branch from cc7e6e4 to 44c5a57 Compare January 8, 2026 21:24
@sfc-gh-nbellante sfc-gh-nbellante changed the title fix: update file chip icon border radius to match Figma design [fix] Update chat input file chip border radius to match Figma Jan 8, 2026
@sfc-gh-nbellante sfc-gh-nbellante changed the title [fix] Update chat input file chip border radius to match Figma [polish] Update chat input file chip border radius to match Figma Jan 8, 2026
@sfc-gh-nbellante sfc-gh-nbellante added security-assessment-completed Security assessment has been completed for PR change:other PR contains other type of change impact:users PR changes affect end users labels Jan 8, 2026
Changed icon container border radius from theme.radii.md (4px) to
theme.radii.default (8px) to match the Figma design specifications.
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the fixit/file-chip-icon-border-radius branch from 44c5a57 to 111ca6a Compare January 8, 2026 22:02
@sfc-gh-nbellante sfc-gh-nbellante merged commit c672a13 into develop Jan 9, 2026
44 checks passed
@sfc-gh-nbellante sfc-gh-nbellante deleted the fixit/file-chip-icon-border-radius branch January 9, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:other PR contains other type of change impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants