[feat] Enhance snapshot hygiene workflow with detailed orphaned snapshot reporting #13238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0000%
✅ Coverage change is within normal range. |
sfc-gh-bnisco
approved these changes
Dec 5, 2025
1bfaccf to
97fce62
Compare
95d8d00 to
8c27e42
Compare
0dda5f8 to
88ed5bb
Compare
a4421ae to
2d6d195
Compare
9a55643 to
269132d
Compare
34c0452 to
375d1ce
Compare
269132d to
b5a64c4
Compare
375d1ce to
42ee566
Compare
283ecd4 to
c70ee41
Compare
42ee566 to
134ee1b
Compare
c70ee41 to
66fafae
Compare
efa9698 to
712ca07
Compare
66fafae to
eaf04eb
Compare
712ca07 to
2ee0af8
Compare
041e881 to
fafd418
Compare
2ee0af8 to
4f10c74
Compare
72ac319 to
ea129ed
Compare
…s are found The workflow was using || which caught the script's exit code 1 and prevented the step from failing. This meant the "Comment on PR if snapshots found" step would never run since it checks if: failure(). Now we: 1. Capture the exit code with set +e 2. Still display and save the output 3. Explicitly exit 1 if the script failed This ensures the workflow correctly fails and comments on PRs when orphaned snapshots are detected.
Changed from 'Copy-pastable list for DISALLOWED_SNAPSHOTS' to 'These are the snapshots I found that appear to be orphaned' for better clarity and tone.
ea129ed to
163d4bf
Compare
14ae0af to
0c6aa0b
Compare
The snapshot output was being interpolated directly into a JavaScript template
literal, which could cause syntax errors or code injection if snapshot filenames
contained backticks, ${, or other special characters.
Now passing the output via environment variable which is the secure way to
handle untrusted data in GitHub Actions workflows.
163d4bf to
96eefa1
Compare
Contributor
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Enhanced the snapshot hygiene workflow to provide more detailed and actionable feedback when orphaned snapshots are detected:
Modified the snapshot-hygiene GitHub workflow to:
Updated the snapshot_cleanup.py script to:
These changes make it easier for developers to identify and address orphaned snapshots by providing a ready-to-use list that can be directly copied into the DISALLOWED_SNAPSHOTS set if needed.
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.