[fix] Do not render sidebar nav when top nav enabled #13227
Merged
+115
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
mayagbarnes
approved these changes
Dec 4, 2025
Contributor
📉 Frontend coverage change detectedThe frontend unit test (vitest) coverage has decreased by 0.0500%
💡 Consider adding more unit tests to maintain or improve coverage. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression where both the sidebar navigation and top navigation were simultaneously visible when the navigation position was set to "top". The fix ensures that when top navigation is enabled, the sidebar navigation is properly hidden.
Key Changes
- Frontend logic now correctly hides sidebar navigation when top navigation position is active
- Comprehensive E2E tests added to verify all three navigation positions (sidebar, top, hidden)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
frontend/app/src/App.tsx |
Adds condition to hide sidebar navigation when effectiveNavigationPosition === Navigation.Position.TOP |
e2e_playwright/st_navigation_test.py |
New E2E tests verifying sidebar, top, and hidden navigation modes work correctly |
e2e_playwright/st_navigation.py |
Test app with dynamic navigation position switching and sidebar content |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
## Describe your changes - Fixes a regression where both the Sidebar and Top nav would be visible when navigation is set to `top`. ## GitHub Issue Link (if applicable) Fixes #13224 ## Testing Plan - Adds e2e tests --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
top.GitHub Issue Link (if applicable)
Fixes #13224
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.