Skip to content

[fix] Improve textarea auto-expansion with proper height calculation and placeholder handling #13168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfc-gh-nbellante wants to merge 1 commit into from
Closed

[fix] Improve textarea auto-expansion with proper height calculation and placeholder handling #13168

sfc-gh-nbellante wants to merge 1 commit into from

Conversation

@sfc-gh-nbellante
Copy link
Contributor

@sfc-gh-nbellante sfc-gh-nbellante commented Dec 1, 2025

Describe your changes

Screenshot or video (only for visual changes)

GitHub Issue Link (if applicable)

Testing Plan

  • Explanation of why no additional tests are needed
  • Unit Tests (JS and/or Python)
  • E2E Tests
  • Any manual testing needed?

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Dec 1, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-13168/streamlit-1.51.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-13168.streamlit.app (☁️ Deploy here if not accessible)

This was referenced Dec 1, 2025
Merged
Merged
@sfc-gh-nbellante Graphite App
Copy link
Contributor Author

sfc-gh-nbellante commented Dec 1, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 1, 2025
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025 •
edited
Loading

📈 Frontend coverage change detected

The frontend unit test (vitest) coverage has increased by 0.0100%

  • Current PR: 89.7500% (51817 lines, 5311 missed)
  • Latest develop: 89.7400% (51789 lines, 5311 missed)

✅ Coverage change is within normal range.

📊 View detailed coverage comparison

@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch from f3f6b6f to de46a9f Compare December 1, 2025 17:45
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-style_updates_to_chat_input branch from 8d81849 to 68a3bb3 Compare December 1, 2025 17:45
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch 2 times, most recently from 2b57692 to b6f6023 Compare December 1, 2025 20:32
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-style_updates_to_chat_input branch from 471e74a to aedf58e Compare December 1, 2025 20:32
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch from b6f6023 to 1c7c5b4 Compare December 1, 2025 21:06
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-style_updates_to_chat_input branch from aedf58e to 70dafb3 Compare December 1, 2025 21:06
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch from 1c7c5b4 to 638684e Compare December 1, 2025 21:24
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-style_updates_to_chat_input branch 2 times, most recently from 1bcb411 to bc83355 Compare December 2, 2025 16:13
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch 3 times, most recently from 6788d11 to ef7ea96 Compare December 2, 2025 17:55
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-style_updates_to_chat_input branch from ab2e804 to caa800c Compare December 2, 2025 17:55
@sfc-gh-nbellante sfc-gh-nbellante added security-assessment-completed Security assessment has been completed for PR change:bugfix PR contains bug fix implementation impact:users PR changes affect end users labels Dec 2, 2025
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch from ef7ea96 to decc186 Compare December 2, 2025 19:48
@sfc-gh-nbellante sfc-gh-nbellante changed the base branch from 11-21-style_updates_to_chat_input to graphite-base/13168 December 2, 2025 20:41
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch from decc186 to fdb375b Compare December 2, 2025 20:42
@graphite-app graphite-app bot changed the base branch from graphite-base/13168 to develop December 2, 2025 20:43
@sfc-gh-nbellante
fix: improve useTextInputAutoExpand maxHeight calculation and tests
6b0e699 
- Calculate maxHeight based on line height for accurate 6.5 line limit
- Handle placeholder text measurement
- Update tests to use real DOM elements for getComputedStyle compatibility
@sfc-gh-nbellante sfc-gh-nbellante force-pushed the 11-21-use_text_input_auto_expand_fix branch from fdb375b to 6b0e699 Compare December 2, 2025 20:43
@sfc-gh-nbellante sfc-gh-nbellante changed the title fix: improve useTextInputAutoExpand maxHeight calculation and tests [fix] Improve textarea auto-expansion with proper height calculation and placeholder handling Dec 2, 2025
sfc-gh-lwilby
sfc-gh-lwilby reviewed Dec 5, 2025
View reviewed changes
...ght/__snapshots__/linux/st_text_area_test/st_text_area-content_height_expanded[chromium].png
Copy link
Collaborator

@sfc-gh-lwilby sfc-gh-lwilby Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems broken to me. The height is supposed to expand to the content like in the original screenshot.

Copy link
Contributor Author

@sfc-gh-nbellante sfc-gh-nbellante Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@sfc-gh-nbellante
Copy link
Contributor Author

sfc-gh-nbellante commented Dec 8, 2025

Deprioritized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-lwilby sfc-gh-lwilby sfc-gh-lwilby left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

change:bugfix PR contains bug fix implementation impact:users PR changes affect end users security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-nbellante @sfc-gh-lwilby