Skip to content

Implement visitTransientNode on most visitors #12823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmcgrady merged 1 commit into from
Dec 1, 2025
Merged

Implement visitTransientNode on most visitors #12823

kmcgrady merged 1 commit into from
Dec 1, 2025

Conversation

@kmcgrady
Copy link
Collaborator

@kmcgrady kmcgrady commented Oct 19, 2025 •
edited
Loading

Describe your changes

We can implement some of the details for Transient Nodes in the visitors. We ignore two places:

  • SetNodeByDeltaPathVisitor - This is a bit complicated and it will be separated out.
  • RenderNodeVisitor - This will be adjusted with the new key setup needed for Transient objects to work properly

Testing Plan

  • Unit tests for the changes are implemented
  • All remaining tests must pass

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snyk-io
Copy link
Contributor

snyk-io bot commented Oct 19, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@kmcgrady kmcgrady added change:refactor PR contains code refactoring without behavior change impact:internal PR changes only affect internal code labels Oct 19, 2025 — with Graphite App
@kmcgrady kmcgrady mentioned this pull request Oct 19, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2025 •
edited
Loading

✅ PR preview is ready!

Name Link
📦 Wheel file https://core-previews.s3-us-west-2.amazonaws.com/pr-12823/streamlit-1.51.0-py3-none-any.whl
📦 @streamlit/component-v2-lib Download from artifacts
🕹️ Preview app pr-12823.streamlit.app (☁️ Deploy here if not accessible)

@kmcgrady kmcgrady added the security-assessment-completed Security assessment has been completed for PR label Oct 19, 2025 — with Graphite App
This was referenced Oct 19, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@kmcgrady Graphite App
Copy link
Collaborator Author

kmcgrady commented Oct 19, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kmcgrady kmcgrady mentioned this pull request Oct 19, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2025 •
edited
Loading

📈 Frontend coverage change detected

The frontend unit test (vitest) coverage has increased by 0.0300%

  • Current PR: 89.2100% (51543 lines, 5560 missed)
  • Latest develop: 89.1800% (51482 lines, 5568 missed)

✅ Coverage change is within normal range.

📊 View detailed coverage comparison

This was referenced Oct 19, 2025
Merged
Merged
Merged
Merged
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from d2b101d to 8cafff6 Compare October 24, 2025 15:05
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from dd57800 to 15ec0e9 Compare October 24, 2025 15:05
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from 8cafff6 to ec390ec Compare October 24, 2025 16:42
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch 2 times, most recently from 258038e to d33a158 Compare October 24, 2025 16:56
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from ec390ec to 9f51720 Compare October 24, 2025 16:56
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

📉 Python coverage change detected

The Python unit test coverage has decreased by 0.0049%

  • Current PR: 92.8575% (20609 statements, 1472 missed)
  • Latest develop: 92.8623% (20609 statements, 1471 missed)

✅ Coverage change is within normal range.

Coverage by files
Name Stmts Miss Cover
streamlit/__init__.py 142 0 100%
streamlit/__main__.py 3 3 0%
streamlit/auth_util.py 100 25 75%
streamlit/cli_util.py 39 6 85%
streamlit/column_config.py 3 0 100%
streamlit/commands/__init__.py 0 0 100%
streamlit/commands/echo.py 54 11 80%
streamlit/commands/execution_control.py 70 10 86%
streamlit/commands/experimental_query_params.py 40 2 95%
streamlit/commands/logo.py 41 6 85%
streamlit/commands/navigation.py 106 2 98%
streamlit/commands/page_config.py 101 4 96%
streamlit/components/__init__.py 0 0 100%
streamlit/components/lib/__init__.py 0 0 100%
streamlit/components/lib/local_component_registry.py 35 2 94%
streamlit/components/types/__init__.py 0 0 100%
streamlit/components/types/base_component_registry.py 14 0 100%
streamlit/components/types/base_custom_component.py 49 6 88%
streamlit/components/v1/__init__.py 5 0 100%
streamlit/components/v1/component_arrow.py 33 8 76%
streamlit/components/v1/component_registry.py 41 3 93%
streamlit/components/v1/components.py 4 4 0%
streamlit/components/v1/custom_component.py 85 7 92%
streamlit/components/v2/__init__.py 24 0 100%
streamlit/components/v2/bidi_component/__init__.py 4 0 100%
streamlit/components/v2/bidi_component/constants.py 5 0 100%
streamlit/components/v2/bidi_component/main.py 152 17 89%
streamlit/components/v2/bidi_component/serialization.py 81 2 98%
streamlit/components/v2/bidi_component/state.py 13 0 100%
streamlit/components/v2/component_definition_resolver.py 30 0 100%
streamlit/components/v2/component_file_watcher.py 117 9 92%
streamlit/components/v2/component_manager.py 97 13 87%
streamlit/components/v2/component_manifest_handler.py 24 0 100%
streamlit/components/v2/component_path_utils.py 68 5 93%
streamlit/components/v2/component_registry.py 121 8 93%
streamlit/components/v2/get_bidi_component_manager.py 8 1 88%
streamlit/components/v2/manifest_scanner.py 224 25 89%
streamlit/components/v2/presentation.py 84 19 77%
streamlit/components/v2/types.py 8 8 0%
streamlit/config.py 412 12 97%
streamlit/config_option.py 79 3 96%
streamlit/config_util.py 288 7 98%
streamlit/connections/__init__.py 6 0 100%
streamlit/connections/base_connection.py 45 0 100%
streamlit/connections/snowflake_connection.py 60 13 78%
streamlit/connections/snowpark_connection.py 44 3 93%
streamlit/connections/sql_connection.py 56 6 89%
streamlit/connections/util.py 33 0 100%
streamlit/cursor.py 82 2 98%
streamlit/dataframe_util.py 501 47 91%
streamlit/delta_generator.py 208 6 97%
streamlit/delta_generator_singletons.py 70 4 94%
streamlit/deprecation_util.py 59 4 93%
streamlit/development.py 1 0 100%
streamlit/elements/__init__.py 0 0 100%
streamlit/elements/alert.py 60 0 100%
streamlit/elements/arrow.py 201 15 93%
streamlit/elements/balloons.py 10 0 100%
streamlit/elements/bokeh_chart.py 9 0 100%
streamlit/elements/code.py 20 1 95%
streamlit/elements/deck_gl_json_chart.py 104 10 90%
streamlit/elements/dialog_decorator.py 38 0 100%
streamlit/elements/doc_string.py 227 9 96%
streamlit/elements/empty.py 16 4 75%
streamlit/elements/exception.py 101 10 90%
streamlit/elements/form.py 54 2 96%
streamlit/elements/graphviz_chart.py 35 1 97%
streamlit/elements/heading.py 56 0 100%
streamlit/elements/html.py 49 0 100%
streamlit/elements/iframe.py 29 0 100%
streamlit/elements/image.py 32 0 100%
streamlit/elements/json.py 39 2 95%
streamlit/elements/layouts.py 140 3 98%
streamlit/elements/lib/__init__.py 0 0 100%
streamlit/elements/lib/built_in_chart_utils.py 390 26 93%
streamlit/elements/lib/color_util.py 100 4 96%
streamlit/elements/lib/column_config_utils.py 169 1 99%
streamlit/elements/lib/column_types.py 189 4 98%
streamlit/elements/lib/dialog.py 67 1 99%
streamlit/elements/lib/dicttools.py 39 2 95%
streamlit/elements/lib/file_uploader_utils.py 30 0 100%
streamlit/elements/lib/form_utils.py 26 0 100%
streamlit/elements/lib/image_utils.py 176 21 88%
streamlit/elements/lib/js_number.py 28 3 89%
streamlit/elements/lib/layout_utils.py 121 1 99%
streamlit/elements/lib/mutable_status_container.py 73 4 95%
streamlit/elements/lib/options_selector_utils.py 90 0 100%
streamlit/elements/lib/pandas_styler_utils.py 80 2 98%
streamlit/elements/lib/policies.py 56 1 98%
streamlit/elements/lib/shortcut_utils.py 42 2 95%
streamlit/elements/lib/streamlit_plotly_theme.py 49 0 100%
streamlit/elements/lib/subtitle_utils.py 76 13 83%
streamlit/elements/lib/utils.py 76 5 93%
streamlit/elements/map.py 110 1 99%
streamlit/elements/markdown.py 65 2 97%
streamlit/elements/media.py 181 8 96%
streamlit/elements/metric.py 104 0 100%
streamlit/elements/pdf.py 49 2 96%
streamlit/elements/plotly_chart.py 129 6 95%
streamlit/elements/progress.py 36 0 100%
streamlit/elements/pyplot.py 39 2 95%
streamlit/elements/snow.py 10 0 100%
streamlit/elements/space.py 12 0 100%
streamlit/elements/spinner.py 34 0 100%
streamlit/elements/text.py 16 0 100%
streamlit/elements/toast.py 26 0 100%
streamlit/elements/vega_charts.py 228 3 99%
streamlit/elements/widgets/__init__.py 0 0 100%
streamlit/elements/widgets/audio_input.py 68 10 85%
streamlit/elements/widgets/button.py 225 5 98%
streamlit/elements/widgets/button_group.py 171 1 99%
streamlit/elements/widgets/camera_input.py 62 10 84%
streamlit/elements/widgets/chat.py 233 58 75%
streamlit/elements/widgets/checkbox.py 52 0 100%
streamlit/elements/widgets/color_picker.py 59 2 97%
streamlit/elements/widgets/data_editor.py 246 14 94%
streamlit/elements/widgets/file_uploader.py 103 18 83%
streamlit/elements/widgets/multiselect.py 105 4 96%
streamlit/elements/widgets/number_input.py 143 5 97%
streamlit/elements/widgets/radio.py 83 5 94%
streamlit/elements/widgets/select_slider.py 97 0 100%
streamlit/elements/widgets/selectbox.py 91 2 98%
streamlit/elements/widgets/slider.py 241 8 97%
streamlit/elements/widgets/text_widgets.py 130 6 95%
streamlit/elements/widgets/time_widgets.py 390 19 95%
streamlit/elements/write.py 166 32 81%
streamlit/emojis.py 4 0 100%
streamlit/env_util.py 21 3 86%
streamlit/error_util.py 33 2 94%
streamlit/errors.py 194 25 87%
streamlit/external/__init__.py 0 0 100%
streamlit/external/langchain/__init__.py 2 0 100%
streamlit/external/langchain/streamlit_callback_handler.py 141 82 42%
streamlit/file_util.py 84 8 90%
streamlit/git_util.py 100 5 95%
streamlit/logger.py 54 0 100%
streamlit/material_icon_names.py 1 0 100%
streamlit/navigation/__init__.py 0 0 100%
streamlit/navigation/page.py 78 2 97%
streamlit/net_util.py 55 3 95%
streamlit/platform.py 10 1 90%
streamlit/runtime/__init__.py 8 0 100%
streamlit/runtime/app_session.py 460 91 80%
streamlit/runtime/caching/__init__.py 19 0 100%
streamlit/runtime/caching/cache_data_api.py 164 3 98%
streamlit/runtime/caching/cache_errors.py 45 4 91%
streamlit/runtime/caching/cache_resource_api.py 122 0 100%
streamlit/runtime/caching/cache_type.py 11 1 91%
streamlit/runtime/caching/cache_utils.py 165 9 95%
streamlit/runtime/caching/cached_message_replay.py 108 1 99%
streamlit/runtime/caching/hashing.py 311 25 92%
streamlit/runtime/caching/legacy_cache_api.py 14 0 100%
streamlit/runtime/caching/storage/__init__.py 2 0 100%
streamlit/runtime/caching/storage/cache_storage_protocol.py 31 2 94%
streamlit/runtime/caching/storage/dummy_cache_storage.py 21 0 100%
streamlit/runtime/caching/storage/in_memory_cache_storage_wrapper.py 60 0 100%
streamlit/runtime/caching/storage/local_disk_cache_storage.py 86 4 95%
streamlit/runtime/connection_factory.py 85 9 89%
streamlit/runtime/context.py 140 0 100%
streamlit/runtime/context_util.py 18 0 100%
streamlit/runtime/credentials.py 139 4 97%
streamlit/runtime/download_data_util.py 27 0 100%
streamlit/runtime/forward_msg_cache.py 23 2 91%
streamlit/runtime/forward_msg_queue.py 63 4 94%
streamlit/runtime/fragment.py 112 2 98%
streamlit/runtime/media_file_manager.py 110 7 94%
streamlit/runtime/media_file_storage.py 15 0 100%
streamlit/runtime/memory_media_file_storage.py 68 0 100%
streamlit/runtime/memory_session_storage.py 15 0 100%
streamlit/runtime/memory_uploaded_file_manager.py 41 1 98%
streamlit/runtime/metrics_util.py 193 12 94%
streamlit/runtime/pages_manager.py 59 2 97%
streamlit/runtime/runtime.py 248 18 93%
streamlit/runtime/runtime_util.py 30 1 97%
streamlit/runtime/script_data.py 16 0 100%
streamlit/runtime/scriptrunner/__init__.py 5 0 100%
streamlit/runtime/scriptrunner/exec_code.py 49 5 90%
streamlit/runtime/scriptrunner/magic.py 83 1 99%
streamlit/runtime/scriptrunner/magic_funcs.py 10 1 90%
streamlit/runtime/scriptrunner/script_cache.py 27 0 100%
streamlit/runtime/scriptrunner/script_runner.py 230 27 88%
streamlit/runtime/scriptrunner_utils/__init__.py 0 0 100%
streamlit/runtime/scriptrunner_utils/exceptions.py 11 1 91%
streamlit/runtime/scriptrunner_utils/script_requests.py 106 5 95%
streamlit/runtime/scriptrunner_utils/script_run_context.py 135 2 99%
streamlit/runtime/secrets.py 242 26 89%
streamlit/runtime/session_manager.py 60 1 98%
streamlit/runtime/state/__init__.py 7 0 100%
streamlit/runtime/state/common.py 52 2 96%
streamlit/runtime/state/presentation.py 19 4 79%
streamlit/runtime/state/query_params.py 134 5 96%
streamlit/runtime/state/query_params_proxy.py 71 0 100%
streamlit/runtime/state/safe_session_state.py 77 9 88%
streamlit/runtime/state/session_state.py 433 29 93%
streamlit/runtime/state/session_state_proxy.py 62 8 87%
streamlit/runtime/state/widgets.py 15 1 93%
streamlit/runtime/stats.py 42 0 100%
streamlit/runtime/theme_util.py 46 1 98%
streamlit/runtime/uploaded_file_manager.py 39 3 92%
streamlit/runtime/websocket_session_manager.py 66 0 100%
streamlit/source_util.py 36 1 97%
streamlit/string_util.py 92 8 91%
streamlit/temporary_directory.py 18 1 94%
streamlit/testing/__init__.py 0 0 100%
streamlit/testing/v1/__init__.py 2 0 100%
streamlit/testing/v1/app_test.py 242 6 98%
streamlit/testing/v1/element_tree.py 1371 87 94%
streamlit/testing/v1/local_script_runner.py 71 2 97%
streamlit/testing/v1/util.py 17 0 100%
streamlit/time_util.py 28 1 96%
streamlit/type_util.py 138 12 91%
streamlit/url_util.py 39 5 87%
streamlit/user_info.py 87 8 91%
streamlit/util.py 38 1 97%
streamlit/version.py 3 0 100%
streamlit/watcher/__init__.py 3 0 100%
streamlit/watcher/event_based_path_watcher.py 181 24 87%
streamlit/watcher/folder_black_list.py 14 1 93%
streamlit/watcher/local_sources_watcher.py 127 9 93%
streamlit/watcher/path_watcher.py 43 3 93%
streamlit/watcher/polling_path_watcher.py 55 2 96%
streamlit/watcher/util.py 49 1 98%
streamlit/web/__init__.py 0 0 100%
streamlit/web/bootstrap.py 153 20 87%
streamlit/web/cache_storage_manager_config.py 5 0 100%
streamlit/web/cli.py 186 17 91%
streamlit/web/server/__init__.py 5 0 100%
streamlit/web/server/app_static_file_handler.py 29 3 90%
streamlit/web/server/authlib_tornado_integration.py 18 1 94%
streamlit/web/server/bidi_component_request_handler.py 65 8 88%
streamlit/web/server/browser_websocket_handler.py 115 31 73%
streamlit/web/server/component_file_utils.py 24 0 100%
streamlit/web/server/component_request_handler.py 55 4 93%
streamlit/web/server/media_file_handler.py 65 9 86%
streamlit/web/server/oauth_authlib_routes.py 118 18 85%
streamlit/web/server/oidc_mixin.py 44 0 100%
streamlit/web/server/routes.py 90 7 92%
streamlit/web/server/server.py 188 11 94%
streamlit/web/server/server_util.py 67 5 93%
streamlit/web/server/stats_request_handler.py 53 4 92%
streamlit/web/server/upload_file_request_handler.py 59 14 76%
streamlit/web/server/websocket_headers.py 19 1 95%
TOTAL 20609 1472 93%

📊 View detailed coverage comparison

@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from d33a158 to f04f690 Compare October 24, 2025 17:47
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from 9f51720 to 24a81bd Compare October 24, 2025 17:47
@kmcgrady kmcgrady marked this pull request as ready for review November 2, 2025 23:24
@kmcgrady kmcgrady requested a review from Copilot November 2, 2025 23:25
graphite-app[bot]
graphite-app bot reviewed Nov 2, 2025
View reviewed changes
Copilot AI reviewed Nov 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements visitor methods for TransientNode across multiple visitor classes, replacing placeholder "Method not implemented" errors with functional implementations. The changes enable proper traversal and manipulation of transient nodes in the render tree.

Key changes:

  • Added updateTransientNodes helper method to TransientNode for filtering/mapping operations
  • Implemented visitTransientNode in 5 visitor classes with appropriate logic for each visitor's purpose
  • Added comprehensive test coverage for all new implementations

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
TransientNode.ts Added updateTransientNodes helper method for filtering/mapping transient node arrays
TransientNode.test.ts Added tests for the new updateTransientNodes method
GetNodeByDeltaPathVisitor.ts Implemented path-based node retrieval for transient nodes
GetNodeByDeltaPathVisitor.test.ts Added tests covering empty paths, valid/invalid indices, and deeper path recursion
FilterMainScriptElementsVisitor.ts Implemented filtering logic for transient nodes based on script hash
FilterMainScriptElementsVisitor.test.ts Added tests for various filtering scenarios
ElementsSetVisitor.ts Implemented element collection from transient nodes and anchors
ElementsSetVisitor.test.ts Added tests for element collection including edge cases
ClearStaleNodeVisitor.ts Implemented stale node clearing logic with fragment run handling
ClearStaleNodeVisitor.test.ts Added tests for fragment runs and stale node scenarios

@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from e2edc05 to c696dd0 Compare November 2, 2025 23:50
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from 8056447 to 89832ac Compare November 2, 2025 23:50
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from c696dd0 to 7cc56f3 Compare November 3, 2025 00:09
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch 2 times, most recently from cf891c6 to b440ae2 Compare November 4, 2025 00:50
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from 89832ac to 7b3b980 Compare November 4, 2025 00:50
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from b440ae2 to 98580f3 Compare November 4, 2025 01:45
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from 7b3b980 to 3aeebea Compare November 4, 2025 01:45
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from 98580f3 to a508d7a Compare November 4, 2025 02:00
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch 2 times, most recently from ba77f88 to 50071ab Compare November 4, 2025 02:14
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch 2 times, most recently from ca0d171 to 8a8cd4b Compare November 5, 2025 03:50
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from 50071ab to 990657a Compare November 5, 2025 03:50
@kmcgrady kmcgrady force-pushed the 10-19-introduce_transientnode branch from 990657a to e49ccdb Compare November 23, 2025 01:50
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from 8a8cd4b to 8c4e150 Compare November 23, 2025 01:50
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

📈 Significant wheel size change detected

The wheel file size has increased by 11.37% (threshold: 0.25%)

  • Current PR: 9873.43 KB
  • Latest develop: 8865.57 KB

Please verify this change is expected.

lukasmasuch
lukasmasuch approved these changes Nov 25, 2025
View reviewed changes
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from 10-19-introduce_transientnode to develop December 1, 2025 15:28
@kmcgrady kmcgrady force-pushed the 10-19-implement_visittransientnode_on_most_visitors branch from 8c4e150 to 5c50853 Compare December 1, 2025 15:28
@kmcgrady kmcgrady mentioned this pull request Dec 1, 2025
Merged
@kmcgrady kmcgrady merged commit b5d4e04 into develop Dec 1, 2025
44 checks passed
@kmcgrady kmcgrady deleted the 10-19-implement_visittransientnode_on_most_visitors branch December 1, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Copilot code review Copilot Copilot left review comments

@lukasmasuch lukasmasuch lukasmasuch approved these changes

Assignees

No one assigned

Labels

change:refactor PR contains code refactoring without behavior change impact:internal PR changes only affect internal code security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmcgrady @lukasmasuch