[Screencast] Fixing countdown bug #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refactor/countdown # Conflicts: # frontend/cypress/snapshots/linux/2x/st_main_menu.spec.ts/main_menu.snap.png # frontend/src/components/core/MainMenu/MainMenu.tsx # frontend/src/hocs/withScreencast/withScreencast.scss # frontend/src/hocs/withScreencast/withScreencast.tsx
… refactor/countdown
… refactor/countdown
tvst
approved these changes
Feb 12, 2020
| /* The menu itself. */ | ||
| div.dropdown-menu { | ||
| width: 12rem; | ||
| width: 13rem; |
Contributor
Author
There was a problem hiding this comment.
Because the new "Cancel screencast" option needs a little bit more space
| let outputBlob | ||
| const { currentState } = this.state | ||
|
|
||
| if (currentState === "OFF") { |
Contributor
There was a problem hiding this comment.
Why is this needed? Is it to avoid line 128 to show an error when state is "OFF"?
If so, just move the OFF check inside the if from line 126.
Contributor
Author
There was a problem hiding this comment.
If the user press stop recording when the screencast is off , we should do nothing otherwise we we'll throw an exception to the frontend
| import "./Countdown.scss" | ||
|
|
||
| interface Props { | ||
| countdown: number |
Contributor
There was a problem hiding this comment.
Why is this a prop? We always count from 3 so this should just be hard-coded.
Contributor
Author
There was a problem hiding this comment.
Because we could use this countdown in a future for a different purpose.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 19, 2020
* develop: (30 commits) [Screencast] Fixing countdown bug (streamlit#1082) Release 0.56.0 (streamlit#1101) Fix bug where icon assets were missing from "make install" (streamlit#1100) Clean signatures of wrapped DeltaGenerator methods (streamlit#1099) Using widgetId as the key when rendering elements (streamlit#1102) Pass --skip-lock to pipenv under pipenv-install Makefile target. (streamlit#1093) Allow wider range of int-like types in NumberInput (streamlit#1087) Fix missing caching URL (streamlit#1094) Version 0.55.1 (just pointing to new docs) (streamlit#1089) Retire python-3.7.4 CircleCI project. (streamlit#1086) Handle different Caching error messages (streamlit#1068) Fix an incomplete copy for a dict that's then modified. (streamlit#1078) Fix indentation error in fad994c. (streamlit#1084) Widgets unit tests (streamlit#1077) [mypy] First phase of work on testing Python type annotations. (streamlit#1079) Add CircleCI jobs to run the oldest and newest Python versions we support. (streamlit#1053) Improve docs (streamlit#1075) Adding CORS to troubleshooting guide. (streamlit#1001) Fix for the CORS check (streamlit#965) Advanced caching updates feb (streamlit#1040) ...
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 19, 2020
# By Nahuel Emiliano Rosso Fandiño (1) and others # Via GitHub * develop: Show warning to user and use skipkeys=True if json.dumps causes TypeError (streamlit#1112) Server: store SessionInfo by id (streamlit#1056) [Screencast] Fixing countdown bug (streamlit#1082) # Conflicts: # lib/streamlit/server/Server.py
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Feb 24, 2020
* develop: (53 commits) Update plotly.js to 1.52 (streamlit#1119) Add tooltip in Altair/Vega-lite docstring code (streamlit#1092) Ability to bind to a server address with server.address config option (streamlit#1107) [mypy] Enable check_untyped_defs throughout the codebase. (streamlit#1110) st.map: set "radiusMinPixels" to 3 (streamlit#1113) st.plotly_chart docs incorrectly refer to Altair (streamlit#1118) Fix BytesIO and numpy array data sources for audio/video (streamlit#1116) Show warning to user and use skipkeys=True if json.dumps causes TypeError (streamlit#1112) Server: store SessionInfo by id (streamlit#1056) [Screencast] Fixing countdown bug (streamlit#1082) Release 0.56.0 (streamlit#1101) Fix bug where icon assets were missing from "make install" (streamlit#1100) Clean signatures of wrapped DeltaGenerator methods (streamlit#1099) Using widgetId as the key when rendering elements (streamlit#1102) Pass --skip-lock to pipenv under pipenv-install Makefile target. (streamlit#1093) Allow wider range of int-like types in NumberInput (streamlit#1087) Fix missing caching URL (streamlit#1094) Version 0.55.1 (just pointing to new docs) (streamlit#1089) Retire python-3.7.4 CircleCI project. (streamlit#1086) Handle different Caching error messages (streamlit#1068) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: This PR fixes a bug when we try to stop recording before the countdown ends
Description:
Contribution License Agreement
By submiting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.