Update the typing-extensions lower verion to >=0.4.4 to fix CI workflow & update snapshots
#10198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typing-extensions lower verion to >=0.4.4 to fix CI workflow
sfc-gh-lwilby
approved these changes
Jan 17, 2025
sfc-gh-braethlein
approved these changes
Jan 17, 2025
sfc-gh-braethlein
left a comment
There was a problem hiding this comment.
LGTM! I personally would split upping the min version of typing-extensions and updating the snapshots if force-merging to get pass the CI failure is possible.
typing-extensions lower verion to >=0.4.4 to fix CI workflowtyping-extensions lower verion to >=0.4.4 to fix CI workflow & update snapshots
Collaborator
Author
Unfortunately, I think I don't have any permission for force-merging or deactivate CI workflows temporarily :( I think my only option to merge this is via one PR. Otherwise, we would need to get some repo admins involved. |
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
…flow & update snapshots (streamlit#10198) ## Describe your changes Fixes our CI min-version test by updating the lower bound of typing-extensions to 0.4.4. This is required by one of our transitive dependencies. More info about the root cause in this PR: python-jsonschema/referencing#211 In addition to the issue with the dependency, there seems to be a second independent issue that broke our CI pipeline: The ubuntu version of our playwright e2e workflow got updated from 22 to 24 yesterday. This caused small changes in how the font is rendered, which required most of our snapshots to be updated. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes our CI min-version test by updating the lower bound of typing-extensions to 0.4.4. This is required by one of our transitive dependencies. More info about the root cause in this PR: python-jsonschema/referencing#211
In addition to the issue with the dependency, there seems to be a second independent issue that broke our CI pipeline:
The ubuntu version of our playwright e2e workflow got updated from 22 to 24 yesterday. This caused small changes in how the font is rendered, which required most of our snapshots to be updated.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.