stream.dash: fix base_url input #6338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzhlkj6612
approved these changes
Dec 14, 2024
Contributor
pzhlkj6612
left a comment
There was a problem hiding this comment.
This is literally a simpler way to fix it. It works!
[cli][debug] Streamlink: 7.0.0+32.g9e67601b
...
[stream.dash][debug] audio/mp4 segment initialization: downloading (1970-01-01T00:00:00.000000Z / 2024-12-14T17:10:26.843548Z)
[stream.dash][debug] video/mp4 segment 1: downloading (1970-01-01T00:00:00.000000Z / 2024-12-14T17:10:26.845548Z)
[stream.dash][debug] video/mp4 segment initialization: completed
[stream.ffmpegmux][debug] Starting copy to pipe: \\.\pipe\streamlinkpipe-255840-1-7343
[stream.ffmpegmux][debug] Starting copy to pipe: \\.\pipe\streamlinkpipe-255840-2-5059
[stream.dash][debug] audio/mp4 segment 1: downloading (1970-01-01T00:00:00.000000Z / 2024-12-14T17:10:26.854135Z)
[stream.dash][debug] audio/mp4 segment initialization: completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of 53ac068
Simply pass the whole input URL as
base_urlvalue, since we're always joining all URLs usingurllib.parse.urljoin().Add another test case which fails on 53ac068 due to the incorrect path splitting, and update all remaining tests.
Fixes #6337
Introduced by #6328
@pzhlkj6612 please check. Thanks!