Skip to content

build: fix build-and-sign script #5550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Sep 12, 2023
Merged

build: fix build-and-sign script #5550

bastimeyer merged 1 commit into from
Sep 12, 2023

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Sep 12, 2023

  • Refactor build script
  • Retrieve version string via the versioningit module
  • Fix the build command of the win32 and win-amd64 wheels (with the streamlinkw gui_scripts entry-points) by adding a workaround that's needed since build>=1.0.0

Resolves #5548

master: 4b1e129
pr: 9b0ed49

$ diff -s \
  <(bsdtar -xOf dist/streamlink-6.1.0+28.g4b1e1298-py3-none-any.whl streamlink-6.1.0+28.g4b1e1298.dist-info/entry_points.txt) \
  <(bsdtar -xOf dist/streamlink-6.1.0+29.g9b0ed496-py3-none-any.whl streamlink-6.1.0+29.g9b0ed496.dist-info/entry_points.txt)
Files /dev/fd/63 and /dev/fd/62 are identical

$ diff -s \
  <(bsdtar -xOf dist/streamlink-6.1.0+28.g4b1e1298-py3-none-win32.whl streamlink-6.1.0+28.g4b1e1298.dist-info/entry_points.txt) \
  <(bsdtar -xOf dist/streamlink-6.1.0+29.g9b0ed496-py3-none-win32.whl streamlink-6.1.0+29.g9b0ed496.dist-info/entry_points.txt)
Files /dev/fd/63 and /dev/fd/62 are identical

$ diff -s \
  <(bsdtar -xOf dist/streamlink-6.1.0+28.g4b1e1298-py3-none-win_amd64.whl streamlink-6.1.0+28.g4b1e1298.dist-info/entry_points.txt) \
  <(bsdtar -xOf dist/streamlink-6.1.0+29.g9b0ed496-py3-none-win_amd64.whl streamlink-6.1.0+29.g9b0ed496.dist-info/entry_points.txt)
Files /dev/fd/63 and /dev/fd/62 are identical

@bastimeyer
build: fix build-and-sign script
9b0ed49 
- Refactor build script
- Retrieve version string via the `versioningit` module
- Fix the `build` command of the `win32` and `win-amd64` wheels
  (with the `streamlinkw` gui_scripts entry-points)
  by adding a workaround that's needed since `build>=1.0.0`
@bastimeyer bastimeyer merged commit 9a3583d into streamlink:master Sep 12, 2023
@bastimeyer bastimeyer deleted the build/fix-build-and-sign branch September 12, 2023 23:10
@bastimeyer bastimeyer mentioned this pull request Sep 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build config

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build-and-sign script currently broken

1 participant

@bastimeyer