Skip to content

build-and-sign script currently broken #5548

@bastimeyer

Description

@bastimeyer

Two issues:

  1. Streamlink's version is currently determined by running python setup.py --version. This has been deprecated by setuptools a while ago and broke in 68.2.1. 68.2.2 has just fixed it, but the proper way of getting the version string is by running

    python -m versioningit

    which is a simple fix.

  2. Windows-specific wheels (streamlinkw "gui_scripts" entry point) are broken since build>=1.0.0 (2023-09-01)

    The build script still uses the deprecated --build-option=--plat-name=${platform} argument which gets passed to setuptools via build's --config-setting argument. --build-option was a flag for setuptools's deprecated CLI and its build command. --plat-name sets the platform for the wheel to be built.
    https://setuptools.pypa.io/en/stable/deprecated/distutils/builtdist.html#cross-compiling-on-windows

    With PEP517 / PEP518, this is all a bit different now.

    I'll need to have a deeper look into setuptools's build backend in order to fix this. This may require overriding and subclassing it (according to some comments on their issue tracker), which would be annoying.

    Thinking about downgrading build in the CI config in the mean time...

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions