-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
Two issues:
-
Streamlink's version is currently determined by running
python setup.py --version. This has been deprecated by setuptools a while ago and broke in68.2.1.68.2.2has just fixed it, but the proper way of getting the version string is by runningpython -m versioningit
which is a simple fix.
-
Windows-specific wheels (
streamlinkw"gui_scripts" entry point) are broken sincebuild>=1.0.0(2023-09-01)The build script still uses the deprecated
--build-option=--plat-name=${platform}argument which gets passed to setuptools viabuild's--config-settingargument.--build-optionwas a flag for setuptools's deprecated CLI and itsbuildcommand.--plat-namesets the platform for the wheel to be built.
https://setuptools.pypa.io/en/stable/deprecated/distutils/builtdist.html#cross-compiling-on-windowsWith PEP517 / PEP518, this is all a bit different now.
I'll need to have a deeper look into setuptools's build backend in order to fix this. This may require overriding and subclassing it (according to some comments on their issue tracker), which would be annoying.
Thinking about downgrading
buildin the CI config in the mean time...