Skip to content

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Feb 9, 2023

Step 2 of 3+x, as detailed in #5145

This PR currently includes the commit of step 1, which will be removed by rebasing once #5149 got merged.

Actual changes of this PR:

  1. add "I" and "TID" import rules, fix import orders of new config and update blank lines after imports to 2
  2. enforce double quotes via "Q" rules
  3. enforce trailing commas via "COM" rules

All code changes in the python modules were automated, with only a few manual changes, e.g. where code-style broke due to the added trailing comma (test_twitch.py), or the removal of superfluous noqa annotations. The "COM" rules also haven't updated everything, e.g. the facebook plugin, but that would require rewriting some stuff, which shouldn't be done here.

Step 3 will add the commit IDs of this PR's changes to .git-blame-ignore-revs, so these automated changes don't get included in any blame views, which is distracting and unnecessary for these kinds of trivial changes.

Any following PRs in regards to ruff will be new linting rules with code changes which are non-trivial, like code refactorings.

@bastimeyer bastimeyer force-pushed the tools/ruff/new-rules-and-style-fixes branch from f118d80 to 32afc33 Compare February 9, 2023 17:59
@gravyboat gravyboat merged commit 57fa6f8 into streamlink:master Feb 9, 2023
@bastimeyer bastimeyer deleted the tools/ruff/new-rules-and-style-fixes branch February 9, 2023 18:32
@bastimeyer bastimeyer mentioned this pull request Feb 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants