tools: replace flake8 with ruff #5149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Apparently there was some kind of hiccup on the side of netlify which let the docs preview build fail and now after the manual re-build there's no status check. Link to the rendered docs here: |
Member
|
This looks good, I don't have time to give the second PR the look it deserves right now, will have to do it later tonight. |
Member
Author
|
#5150 only includes trivial changes, so apart from scrolling through the entire diff, there's not much going on. The diff view on GitHub unfortunately is (still) terrible, and looking at the diff locally is just way more efficient. |
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of 3+x, as detailed in #5145
This replaces
flake8and plugins withruff, sets a similar config, and updates the docs.The import linting config is missing and will be added in a subsequent PR via ruff's
isort"I" rules, which are slightly different and require lots of module code changes. This PR only changes the bare minimum for having a short diff without any code changes.