plugins.rtve: fix ZTNR.translate #4840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0b9121 to
ff4666b
Compare
|
Hi @bastimeyer tested and works fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4838
As mentioned in #4838 (comment), it's possible (very likely) that the whole embedded and obfuscated stream URL data extraction is useless now. Since I'm not fully sure, I've kept it for now. I've also wrapped the HTTP request which retrieves the obfuscated data into a try-except block, so that if the site removes the endpoint, the plugin will continue working with the generic HLS URL template.
I only tested the URLs listed in the URL matcher tests. The site is also geo-blocked (on the HLS playlist level), so I can't fully test it anyway. The main issue however should be fixed (the old while-loop - see #4838 (comment)).
@jairoxyz I would appreciate it if you could test the PR before this gets merged. Thanks.