Skip to content

plugins.okru: support mobile page #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Aug 28, 2022
Merged

plugins.okru: support mobile page #4780

bastimeyer merged 1 commit into from
Aug 28, 2022

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Aug 27, 2022

Resolves #4682
Reverts #4779

I removed the exception handling of the PluginError, because validation error messages are useful now.

Mobile HLS

$ streamlink 'https://mobile.ok.ru/live/1366902775399'
[cli][info] Found matching plugin okru for URL https://mobile.ok.ru/live/1366902775399
Available streams: 240p (worst), 360p, 480p, 720p (best)

Mobile HTTP

$ streamlink 'https://mobile.ok.ru/dk?st.cmd=movieLayer&st.groupId=70000000124591&st.discId=4242734320303&st.retLoc=top&st.rtu=%2Fdk%3Fst.cmd%3DuserMovies%26st.page%3D1%26_prevCmd%3DuserMovies%26tkn%3D8051&st.discType=GROUP_MOVIE&st.mvId=4242734320303&_prevCmd=userMovies&tkn=3276#'
[cli][info] Found matching plugin okru for URL https://mobile.ok.ru/dk?st.cmd=movieLayer&st.groupId=70000000124591&st.discId=4242734320303&st.retLoc=top&st.rtu=%2Fdk%3Fst.cmd%3DuserMovies%26st.page%3D1%26_prevCmd%3DuserMovies%26tkn%3D8051&st.discType=GROUP_MOVIE&st.mvId=4242734320303&_prevCmd=userMovies&tkn=3276#
Available streams: vod (worst, best)

Main site:

$ streamlink 'https://ok.ru/video/266205792931'
[cli][info] Found matching plugin okru for URL https://ok.ru/video/266205792931
Available streams: 144p (worst), 240p, 360p, 480p (best)

@bastimeyer bastimeyer added the plugin enhancement A new feature for a working Plugin label Aug 27, 2022
@bastimeyer bastimeyer requested a review from mkbloke August 27, 2022 21:06
UltraHDR
UltraHDR reviewed Aug 28, 2022
View reviewed changes
src/streamlink/plugins/okru.py Outdated
"""
$description Russian live-streaming and video hosting social platform.
$url ok.ru
$url m.ok.ru
Copy link
Contributor

@UltraHDR UltraHDR Aug 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$url m.ok.ru
$url m.ok.ru
$url mobile.ok.ru

Copy link
Member Author

@bastimeyer bastimeyer Aug 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the docs, which show which sites are supported by the plugin. Listing every kind of hostname variation is unnecessary. I updated it to mobile.ok.ru though, to make it more clear that it's the mobile version of the site, and that it's different.

@bastimeyer bastimeyer force-pushed the plugins/okru/mobile-streams branch from d3ce33b to 9dfbd90 Compare August 28, 2022 09:11
@bastimeyer bastimeyer mentioned this pull request Aug 28, 2022
Merged
@bastimeyer
Copy link
Member Author

bastimeyer commented Aug 28, 2022

Going to merge this myself now, so I can fix the merge conflict.

@bastimeyer bastimeyer merged commit f219e7f into streamlink:master Aug 28, 2022
@bastimeyer bastimeyer deleted the plugins/okru/mobile-streams branch August 28, 2022 09:30
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Sep 3, 2022
@Billy2011
[PATCH] plugins.okru: support mobile page(streamlink#4780)
995fa3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkbloke mkbloke Awaiting requested review from mkbloke

1 more reviewer

@UltraHDR UltraHDR UltraHDR left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin enhancement A new feature for a working Plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mobile.ok.ru

2 participants

@bastimeyer @UltraHDR