plugins: call schema.validate(value) #4718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should be the last plugin schema updates from me for now. As said on the streamlink Gitter channel, there are a couple of validation schemas left that could be refined according to the newly added stuff, but there are some problems.
That can be removed. It's not used by any plugin, and if 3rd party plugins import from that module, then they can re-implement it.
There's already a PR for that plugin.
I have local changes for that, but I don't want to submit a PR, as I can't test it. The site requires a registration with a Belgian address. The current implementation is most likely broken.
I've got local changes for that plugin as well, but I haven't tested it yet, as it requires having an account. Maybe I'll take a look at this later, but not now.
Forgot to stage some changes after stashing and rebasing all the plugin changes a couple of times. Won't open another PR for that.
And then there are tons of other plugins with bad validation schema definitions and bad code styles. Fixing and updating those was not the plan in my recent changes.