Skip to content

plugins.nbcnews: fix plugin #4668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gravyboat merged 1 commit into from
Jul 20, 2022
Merged

plugins.nbcnews: fix plugin #4668

gravyboat merged 1 commit into from
Jul 20, 2022

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Jul 20, 2022

Closes #4664

Cleanup of the issues mentioned in my review of #4664, with a plugin rewrite

$ streamlink -l debug nbcnews.com/now
[cli][debug] OS:         Linux-5.18.11-1-git-x86_64-with-glibc2.35
[cli][debug] Python:     3.10.5
[cli][debug] Streamlink: 4.2.0+15.g20db6378
[cli][debug] Dependencies:
[cli][debug]  isodate: 0.6.1
[cli][debug]  lxml: 4.9.0
[cli][debug]  pycountry: 22.3.5
[cli][debug]  pycryptodome: 3.14.1
[cli][debug]  PySocks: 1.7.1
[cli][debug]  requests: 2.28.1
[cli][debug]  websocket-client: 1.3.2
[cli][debug] Arguments:
[cli][debug]  url=nbcnews.com/now
[cli][debug]  --loglevel=debug
[cli][debug]  --player=mpv
[cli][info] Found matching plugin nbcnews for URL nbcnews.com/now
[plugins.nbcnews][debug] API ID: 2007524
[utils.l10n][debug] Language code: en_US
Available streams: 144p_alt (worst), 144p, 216p_alt, 216p, 288p_alt, 288p, 360p_alt, 360p, 504p_alt, 504p, 576p_alt, 576p, 720p_alt, 720p, 1080p_alt, 1080p (best)

@bastimeyer @Grabien
plugins.nbcnews: fix plugin
20db637 
Co-Authored-By: Grabien <max@grabien.com>
@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jul 20, 2022
@gravyboat gravyboat merged commit a577e6c into streamlink:master Jul 20, 2022
@bastimeyer bastimeyer deleted the plugins/nbcnews/fix branch July 20, 2022 22:35
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Jul 23, 2022
@Billy2011 @Grabien
[PATCH] plugins.nbcnews: fix plugin(streamlink#4668)
e97de0f 
Co-Authored-By: Grabien <max@grabien.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bastimeyer @gravyboat