cli: refactor nested argparse argument groups #4651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a custom mapping of parent->child argument group relations instead of calling `group.add_argument_group()` for creating a tree structure of argument groups (deprecated in Python 3.11) - Override `parser.add_argument_group()` and add the `parent` keyword for being able to have nested argument group defintions - Update custom `--help` format output - Update the argparser Sphinx extension - Fix tests
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Jul 18, 2022
- Use a custom mapping of parent->child argument group relations instead of calling `group.add_argument_group()` for creating a tree structure of argument groups (deprecated in Python 3.11) - Override `parser.add_argument_group()` and add the `parent` keyword for being able to have nested argument group defintions - Update custom `--help` format output - Update the argparser Sphinx extension - Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of calling
group.add_argument_group()for creatinga tree structure of argument groups (deprecated in Python 3.11)
parser.add_argument_group()and add theparentkeywordargument to nested group defintions
--helpformat outputResolves #4648
Help text stays the same, and so do the docs (see the preview build).
$ diff \ <(~/venv/streamlink-310/bin/streamlink --help) \ <(~/venv/streamlink-311/bin/streamlink --help) $ echo $? 0