Skip to content

plugins.twitch: new plugin command --twitch-api-header #4156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gravyboat merged 1 commit into from
Nov 6, 2021
Merged

plugins.twitch: new plugin command --twitch-api-header #4156

gravyboat merged 1 commit into from
Nov 6, 2021

Conversation

@back-to
Copy link
Collaborator

@back-to back-to commented Nov 6, 2021 •
edited
Loading

  • can be used for Authorization or other headers
  • change PlaybackAccessToken playerType to site as embed will show ads
  • remove some unsed HLS and headers code
streamlink https://twitch.tv/twitch best \
    --twitch-api-header "X-Device-Id=twitch-web-wall-mason" \
    --twitch-api-header "Device-Id=twitch-web-wall-mason"

closes #4080

@back-to back-to added the plugin enhancement A new feature for a working Plugin label Nov 6, 2021
bastimeyer
bastimeyer reviewed Nov 6, 2021
View reviewed changes
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's GQL (Graph Query Language), not GPL.

Adding a generic parameter for adjusting the API requests headers makes more sense than adding multiple ones for specific authentication/identification methods, so I'm in favor of that. The problem here though is that it's not particularly user-friendly, but neither is extracting headers from the web browser, so it's fine.

@bastimeyer
Copy link
Member

bastimeyer commented Nov 6, 2021

It might be better to just call it twitch-api-header. This is less confusing, people don't have to memorize specific names (gql) and it's shorter (no http-).

@back-to
plugins.twitch: new plugin command --twitch-api-header
efc5b6c 
- allow user header for api http requests
- can be used for `Authorization` or other headers
- change PlaybackAccessToken playerType to `site` as `embed` will show ads
- remove some unsed HLS and headers code

---

```
streamlink https://twitch.tv/twitch best \
    --twitch-api-header "X-Device-Id=twitch-web-wall-mason" \
    --twitch-api-header "Device-Id=twitch-web-wall-mason"
```
@back-to back-to changed the title plugins.twitch: allow user headers for gpl api plugins.twitch: new plugin command --twitch-api-header Nov 6, 2021
@bastimeyer
Copy link
Member

bastimeyer commented Nov 6, 2021

playerType="site" also causes (preroll-)ads. There's no difference. Did you get midroll ads with embed or why did you change it?

@back-to
Copy link
Collaborator Author

back-to commented Nov 6, 2021

server_ads will be False with site but True with embed

[plugins.twitch][debug] {'adblock': False, 'geoblock_reason': '', 'hide_ads': False, 'server_ads': False, 'show_ads': True}

when used with

streamlink https://twitch.tv/twitch best \
    --twitch-api-header "X-Device-Id=twitch-web-wall-mason" \
    --twitch-api-header "Device-Id=twitch-web-wall-mason"

@gravyboat gravyboat merged commit dfea62a into streamlink:master Nov 6, 2021
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Nov 9, 2021
@Billy2011
[PATCH] plugins.twitch: new plugin command --twitch-api-header (strea…
585f721 
…mlink#4156)
@back-to back-to deleted the TwitchGPL branch November 11, 2021 18:44
This was referenced Nov 21, 2021
Closed
Merged
This was referenced Nov 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bastimeyer bastimeyer bastimeyer approved these changes

Assignees

No one assigned

Labels

plugin enhancement A new feature for a working Plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@back-to @bastimeyer @gravyboat