setup: remove NO_DEPS env var #4115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added by 080c163 8 years ago.
https://github.com/streamlink/streamlink/blame/42ca168b27a71bba9812f6909923acaebbe5e1a1/setup.py#L64-L67
This was meant for the Windows installer which was based on the
bdist_eggegg distribution back then. Totally outdated nowadays and the installer was rewritten after the fork anyway.NO_DEPSis not needed when building Streamlink via setuptools'build/installcommands, and nobody will use it for building sdist/bdist_wheel without any dependencies defined, so it can be removed safely.