-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.twitch: add device-id headers #4086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`server_ads` is `False` and should skip ADs for now,
also show some debug informations.
```json
{
'adblock': False,
'geoblock_reason': '',
'expires': 163300000,
'hide_ads': False,
'server_ads': False,
'show_ads': True
}
```
Ref https://github.com/pixeltris/TwitchAdSolutions/blob/master/bypass/bypass-ublock-origin.js
bastimeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same cat-and-mouse game once again (fourth time that we're adding special headers or params). If Twitch decides to block all access token requests with these headers, then this will break the entire plugin - just saying... We can try adding it though, but keep in mind that there's currently a breaking change on the master branch, which would make an "emergency release" a bit unprepared.
as well as access token debug logging
|
Can someone confirm? Midroll ads are far worse for Streamlink's output due to the stream discontinuities. Filtering out preroll ads just delays the stream start. |
|
Can confirm that "twitch-web-wall-mason" doesn't work anymore, causes midroll screen. |
as well as access token debug logging
server_adsisFalseand should skip ADs for now,also show some debug informations.
Ref https://github.com/pixeltris/TwitchAdSolutions/blob/master/bypass/bypass-ublock-origin.js
Ref #3210