add --niconico-timeshift-offset option to the nicolive plugin #3425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back-to
reviewed
Dec 20, 2020
src/streamlink/plugins/nicolive.py
Outdated
| offset = self.get_option("timeshift-offset") | ||
| if offset: | ||
| if 'timeshift' in self.wss_api_url: | ||
| self.hls_stream_url += '&start={0}'.format(offset) |
Collaborator
There was a problem hiding this comment.
src/streamlink/plugins/nicolive.py
Outdated
Comment on lines
258
to
260
| _log.debug("Timeshift offset stream URL is now {0}".format(self.hls_stream_url)) | ||
| else: | ||
| _log.debug("Not a timeshift video, ignoring offset") |
src/streamlink/plugins/nicolive.py
Outdated
| self.hls_stream_url = data["uri"] | ||
| # load in the offset for timeshift live videos | ||
| offset = self.get_option("timeshift-offset") | ||
| if offset: |
Collaborator
There was a problem hiding this comment.
if offset and 'timeshift' ...
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 21, 2020
…eamlink#3425) --niconico-timeshift-offset allows the nicolive Streamlink plugin to start at a particular timestamp in the HLS stream for timeshift streams. http://help.nicovideo.jp/live_en/2013/06/305what-is-a-timeshiftwatch-period.html This proves particularly useful because some broadcasts' HLS streams start with a long "waiting room" during a live broadcast that the web player skips past by default.
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 22, 2020
…eamlink#3425) --niconico-timeshift-offset allows the nicolive Streamlink plugin to start at a particular timestamp in the HLS stream for timeshift streams. http://help.nicovideo.jp/live_en/2013/06/305what-is-a-timeshiftwatch-period.html This proves particularly useful because some broadcasts' HLS streams start with a long "waiting room" during a live broadcast that the web player skips past by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--niconico-timeshift-offsetallows the nicolive Streamlink plugin to start at a particular timestamp in the HLS stream for timeshift streams.This proves particularly useful because some broadcasts' HLS streams start with a long "waiting room" during a live broadcast that the web player skips past by default.