stream.dash: allow '_alt' streams with the same resolution #3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a list of stream_names and rename streams with the same resolution - `defaultdict` seems the easy way without changing a lot of tests - added `test_10.mpd`, so we have an actual test file for future updates
bastimeyer
reviewed
Dec 12, 2020
Member
bastimeyer
left a comment
There was a problem hiding this comment.
Do you want to keep this naming scheme? Plugin.streams() renames the duplicates like this, without the second underscore character:
foo, foo_alt, foo_alt2
streamlink/src/streamlink/plugin/plugin.py
Lines 365 to 366 in 275febc
src/streamlink/stream/dash.py
Outdated
Comment on lines
260
to
261
| else: | ||
| ret_new[f'{q}_alt_{n}'] = items[n] |
Member
There was a problem hiding this comment.
Without a third height=1080 entry in test_parse_manifest_with_duplicated_resolutions, the else-block is not covered by the tests.
Collaborator
Author
|
changed it to |
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 13, 2020
Billy2011
added a commit
to Billy2011/streamlink-27
that referenced
this pull request
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultdictseems the easy way without changing a lot of teststest_10.mpd, so we have an actual test file for future updatescloses #3365