Codecov Report

Merging #1925 into master will decrease coverage by 0.3%.
The diff coverage is 14.07%.

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
- Coverage   51.57%   51.27%   -0.31%     
==========================================
  Files         242      242              
  Lines       14246    14155      -91     
==========================================
- Hits         7348     7258      -90     
+ Misses       6898     6897       -1

I like it. But, why is this commit 32e2458 included? Shouldn't you rebase on the upstream master to get this included.

you are still behind

https://github.com/Billy2011/streamlink/tree/api-http-fix

if you don't want to handle conflicts,
remove the changes in TV4Play before you start

this will REMOVE your last commit, but the files won't change

git reset --soft HEAD~1

git reset HEAD src/streamlink/plugins/tv4play.py
git checkout src/streamlink/plugins/tv4play.py
git commit -m "part 2 of 2; replace global http session by self.session.http"

small rebase guide

update your master branch

git checkout master
git pull upstream master

check the commit it should be 6bf654a291e2a792088384c7ba7c9dc9b2a14b1d

git show --name-status

change back to api-http-fix

git checkout api-http-fix

git rebase master

you will have to handle conflicts there
or update tv4play after if you removed it

All PR's end up with me - it is no longer possible to create a PR for streamlink???

I think it should work now, if you push something to Billy2011:api-http-fix

What's happening here? :D

I've been wondering the same thing all day (•ิ_•ิ)?

How can I fix the test plugins garena + tvplayer?
That, for example, no longer exists: streamlink.plugins.garena.http

@Billy2011 Billy2011#10 :)

Missed 2 plugins.

https://github.com/Billy2011/streamlink/blob/api-http-fix/src/streamlink/plugins/bongacams.py#L48-L49
https://github.com/Billy2011/streamlink/blob/api-http-fix/src/streamlink/plugins/tvrplus.py#L30

Must the global var. api.http and all remaining references to it be preserved?
Why is there a streamlink session reference in the Plugin class if it is not explicitly used?
Unfortunately, requests is not completely thread safe and a global api.http will not improve that.

Anything that referrers to the global should be removed. While it won’t help with the thread safety, we will have more control - for example, we could create one session per thread ID (not sure if that’s actually a workable idea).

I think the last reference to api.http is in streamlink.session, should I remove that?

I think the last reference to api.http is in streamlink.session, should I remove that?

@Billy2011 Can you post a line reference? Maybe that one will have to be done separately :)

@beardypig, in line 469 api.http = self.http

@Billy2011 I believe that would make it a breaking change. We should open a separate PR for that, and probably keep it open until we are ready for 1.0.0 :)

With this PR, there should be nothing using it - but custom plugins might use it, as we provide an API that other people can use this should be considered a break change and will require a major version bump. If there are more breaking changes we want to make we should do those for 1.0.0 as well.

OK, then I hope that this PR is ready to merge and no other member raises an objection :)

Alright let's get this in then, thanks for the hard work @Billy2011, and for the feedback everyone!