plugins.crunchyroll: refactoring and updated API calls #1820
Conversation
This fixes the session issue streamlink#1574 using the API rather than the website, as this change caused some other issues.
- don't cache the session_id - don't login when using a user set session_id
Codecov Report
@@ Coverage Diff @@
## master #1820 +/- ##
=========================================
- Coverage 50% 50% -0.01%
=========================================
Files 234 234
Lines 13852 13864 +12
=========================================
+ Hits 6927 6933 +6
- Misses 6925 6931 +6 |
|
Good stuff @beardypig, I think this is good to go unless you have something else you want to add as it has resolved the original issue. |
|
I would be nice if @Atemu could give it a try to see if their problem is still solved. |
|
Sure, getting a US Session ID via the method I used still doesn't work for the Monogatari series (eventhough it works for all other geo blocked content I've tried), but the ID Streamlink generates when using a US VPN or proxy now works flawlessly. I just had to adjust my scripts to use an actual proxy instead of the other method. Thanks a bunch @beardypig ! |
@Atemu were you generating a session id with an account? |
|
Don't think so, but it had nothing to do with Streamlink (I only assumed it did because Streamlink didn't generate the ID properly either) and shouldn't really have worked in the first place. |
|
@gravyboat I think it's good to go. |
|
Good stuff, thanks @beardypig. |
* plugins.crunchyroll: refactoring and updated API calls This fixes the session issue streamlink#1574 using the API rather than the website, as this change caused some other issues. * plugins.crunchyroll: do not cache session id - don't cache the session_id - don't login when using a user set session_id
This fixes the session issue #1574 using the API rather than the website, as this change caused some other issues.
The only changes I might make are to the X-Android headers, as it is pretty obviously the emulator.
I added a small convenience parameter to
cache.setto allow you to set an expiry time rather than expiry duration. (Need to add tests for this)Should fix #1808.