fix: dont patch getuid and getgid on process anymore #809#847
Merged
G-Rath merged 1 commit intostreamich:masterfrom Jun 24, 2022
Merged
fix: dont patch getuid and getgid on process anymore #809#847G-Rath merged 1 commit intostreamich:masterfrom
getuid and getgid on process anymore #809#847G-Rath merged 1 commit intostreamich:masterfrom
Conversation
G-Rath
requested changes
Jun 7, 2022
Collaborator
G-Rath
left a comment
There was a problem hiding this comment.
Looks good, just need to restore the uid property.
Would you be open to also replacing getgid in this PR too, since that change is pretty much the same thing?
G-Rath
reviewed
Jun 18, 2022
Comment on lines
9
to
12
| it('.getuid() and .getgid()', () => { | ||
| expect(typeof proc.getuid()).toBe('number'); | ||
| expect(typeof proc.getgid()).toBe('number'); | ||
| expect(typeof proc.getuid?.() ?? 0).toBe('number'); | ||
| expect(typeof proc.getgid?.() ?? 0).toBe('number'); | ||
| }); |
Collaborator
There was a problem hiding this comment.
nit: we should remove this test entirely as it's not really covering anything useful now
process.getuid under Windows #809getuid and getgid on process anymore #809
G-Rath
approved these changes
Jun 24, 2022
streamich
pushed a commit
that referenced
this pull request
Jun 24, 2022
## [3.4.7](v3.4.6...v3.4.7) (2022-06-24) ### Bug Fixes * dont patch `getuid` and `getgid` on `process` anymore ([#847](#847)) ([1c19e87](1c19e87))
Owner
|
🎉 This PR is included in version 3.4.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #809