fix: handle Uint8Array byteOffset and byteLength in readSync#1184
Merged
streamich merged 3 commits intostreamich:masterfrom Sep 25, 2025
Merged
fix: handle Uint8Array byteOffset and byteLength in readSync#1184streamich merged 3 commits intostreamich:masterfrom
streamich merged 3 commits intostreamich:masterfrom
Conversation
Collaborator
|
Thanks, any chance you could add a test for this? |
Contributor
Author
|
No worries, all done
…On Tue, 16 Sep 2025 at 6:09 pm, Gareth Jones ***@***.***> wrote:
*G-Rath* left a comment (streamich/memfs#1184)
<#1184 (comment)>
Thanks, any chance you could add a test for this?
—
Reply to this email directly, view it on GitHub
<#1184 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADSZ4SMBFLZM6RFHCHE5TL3S7ATJAVCNFSM6AAAAACGT3S3GWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOJWGQ3DKNBXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
I cannot push to your branch @mattfysh, please run |
Contributor
Author
|
donezos! |
Contributor
|
🎉 This PR is included in version 4.46.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.