Skip to content

Add python 3.13 tests on our CI#254

Merged
Ckk3 merged 8 commits intostrawberry-graphql:mainfrom
Ckk3:add-python-3.13-tests
Jun 21, 2025
Merged

Add python 3.13 tests on our CI#254
Ckk3 merged 8 commits intostrawberry-graphql:mainfrom
Ckk3:add-python-3.13-tests

Conversation

@Ckk3
Copy link
Copy Markdown
Contributor

@Ckk3 Ckk3 commented Jun 21, 2025 •
edited by sourcery-ai bot
Loading

Description

Add Python 3.13 to GitHub Actions and Nox testing configurations.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery

Tests:

  • Add Python 3.13 to GitHub Actions and Nox testing configurations.

Summary by Sourcery

Add Python 3.13 to the project's CI and testing configurations and update dependencies for compatibility

Enhancements:

  • Adjust asyncpg dependency constraints for Python 3.13 and bump psycopg2 to version 2.9.10

CI:

  • Include Python 3.13 in the GitHub Actions test matrix

Documentation:

  • Add RELEASE.md with patch release notes and Python 3.13 compatibility details

Tests:

  • Extend Nox testing sessions to run on Python 3.13

@Ckk3 Ckk3 self-assigned this Jun 21, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jun 21, 2025 •
edited
Loading

Reviewer's Guide

This PR integrates Python 3.13 into the CI and testing setup by extending GitHub Actions and nox configurations, adjusts dependency constraints for compatibility, and adds release documentation.

File-Level Changes

Change Details Files
Incorporate Python 3.13 into CI pipelines
  • Update GitHub Actions test matrix to use ‘3.13’ instead of ‘3.13-dev’
  • Include Python 3.13 in cache key matrix
  • Prepend ‘3.13’ to nox PYTHON_VERSIONS list
 .github/workflows/test.yml
noxfile.py
Adjust dependency constraints for Python 3.13 compatibility
  • Add psycopg2 to top-level dependencies and bump its version
  • Update dev psycopg2 version to ‘>=2.9.10’
  • Make asyncpg version conditional on Python version (<3.13 vs ≥3.13)
 pyproject.toml
Add release documentation
  • Create RELEASE.md with patch release notes and Python 3.13 support summary
 RELEASE.md
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jun 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ckk3 - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (fa4eb67) to head (e20f067).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
+ Coverage   89.72%   91.18%   +1.46%     
==========================================
  Files          17       16       -1     
  Lines        1936     1905      -31     
  Branches      145      145              
==========================================
  Hits         1737     1737              
+ Misses        125       94      -31     
  Partials       74       74
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #254 will not alter performance

Comparing Ckk3:add-python-3.13-tests (e20f067) with main (fa4eb67)

Summary

✅ 1 untouched benchmarks

@botberry
Copy link
Copy Markdown
Member

botberry commented Jun 21, 2025 •
edited
Loading

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This update helps verify compatibility with Python 3.13.

  • Added new test environments in the CI pipeline to ensure compatibility with Python 3.13.
  • No changes to runtime code or dependencies.

@Ckk3 Ckk3 marked this pull request as draft June 21, 2025 03:06
@Ckk3 Ckk3 marked this pull request as ready for review June 21, 2025 03:24
sourcery-ai[bot]
sourcery-ai bot reviewed Jun 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ckk3 - I've reviewed your changes - here's some feedback:

  • The psycopg2 dependency is pinned exactly in both the main and dev groups—consider unifying these entries or using a caret range to avoid having to bump patch versions twice.
  • Until Python 3.13 final is released, you may want to keep 3.13-dev in your CI matrix to catch any last-minute breakages before the stable release.
Prompt for AI Agents 
Please address the comments from this code review:
## Overall Comments
- The psycopg2 dependency is pinned exactly in both the main and dev groups—consider unifying these entries or using a caret range to avoid having to bump patch versions twice.
- Until Python 3.13 final is released, you may want to keep `3.13-dev` in your CI matrix to catch any last-minute breakages before the stable release.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Ckk3 Ckk3 merged commit 49da15f into strawberry-graphql:main Jun 21, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@Ckk3 Ckk3

Labels

bot:has-release-file bot:release-type-patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ckk3 @botberry