fix(rulesets): exclude non-schema enum properties from duplicated-entry-in-enum rule#2934
Merged
Merged
Conversation
…ry-in-enum rule The duplicated-entry-in-enum rule was incorrectly firing on properties named 'enum' in contexts like discriminator mappings and example values, where 'enum' is a data field rather than a JSON Schema keyword. Narrow the JSONPath filter to only match when the 'enum' value is actually an array, which is the only valid form for a schema enum keyword. Fixes stoplightio#2199
fc4f6c6 to
6472ad8
Compare
tomek-tursa-sb
previously approved these changes
Apr 22, 2026
Contributor
There was a problem hiding this comment.
changes in this file are probably redundant
Contributor
Author
|
Thanks for the ping, @tomek-tursa-sb. You were right — the generated Arazzo validators bundle change was redundant for this fix. I restored |
Contributor
|
@slegarraga thank you for this contribution 💪 |
tomek-tursa-sb
approved these changes
May 20, 2026
stoplight-bot
pushed a commit
that referenced
this pull request
May 21, 2026
## @stoplight/spectral-rulesets [1.22.3](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-1.22.2...@stoplight/spectral-rulesets-1.22.3) (2026-05-21) ### Bug Fixes * **rulesets:** exclude non-schema enum properties from duplicated-entry-in-enum rule ([#2934](#2934)) ([a7822fa](a7822fa)), closes [#2199](#2199)
stoplight-bot
pushed a commit
that referenced
this pull request
May 21, 2026
## [1.12.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-1.12.0...@stoplight/spectral-ruleset-migrator-1.12.1) (2026-05-21) ### Bug Fixes * **deps:** post lodash update changes for semantic release ([#2942](#2942)) ([bf530dd](bf530dd)) * **ruleset-migrator:** handle non function objects returned by requireResolve ([#2957](#2957)) ([60c6c56](60c6c56)) * **rulesets:** exclude non-schema enum properties from duplicated-entry-in-enum rule ([#2934](#2934)) ([a7822fa](a7822fa)), closes [#2199](#2199) * **rulesets:** fix handling relative references in externalValue ([#2944](#2944)) ([6666ccc](6666ccc)), closes [#2819](#2819) ### Features * **core:** add error line number for yaml and json ruleset validation ([#2945](#2945)) ([04c1db3](04c1db3))
Collaborator
|
🎉 This PR is included in version 1.22.3 🎉 The release is available on Your semantic-release bot 📦🚀 |
anderaus
reviewed
May 21, 2026
| recommended: true, | ||
| message: '{{error}}', | ||
| given: ["$..[?(@property !== 'properties' && @ && @.enum)]"], | ||
| given: ["$..[?(@property !== 'properties' && @.enum && @.enum.constructor.name === 'Array')]"], |
There was a problem hiding this comment.
Was the @ && null guard removed on purpose? I believe I'm seeing crashes when nimma hits a null node.
There was a problem hiding this comment.
Shouldn't this be:
$..[?(@property !== 'properties' && @ && @.enum && @.enum.constructor.name === 'Array')]
This was referenced Jun 10, 2026
hdamker
added a commit
to camaraproject/tooling
that referenced
this pull request
Jun 11, 2026
rulesets 1.22.3 (pulled in by the redocly/cli lockfile regen) crashes Spectral on r4 specs with null example values — upstream regression stoplightio/spectral#2934 dropped a null guard in duplicated-entry-in-enum. 1.22.2 is the last pre-regression release; drop the pin once a fixed release ships. Fixes #328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplicated-entry-in-enum rule was incorrectly triggering when enum is used as a property name in contexts like discriminator mappings or example values, rather than as a JSON Schema keyword. For example, a discriminator mapping like
mapping: { enum: ... }or example data with anenumfield would wrongly trigger the rule.The fix narrows the JSONPath filter to only match when the enum value is actually an array, since a JSON Schema enum keyword must have an array value. This avoids false positives while still correctly catching duplicate entries in actual schema enums.
Checklist
Does this PR introduce a breaking change?