feat(core): aliases take only array-ish given#2033
Conversation
dd22a58 to
37d92e9
Compare
marbemac
left a comment
There was a problem hiding this comment.
👍 nice - and always have the option to introduce non-array syntax in the future if there's high demand / use case for it.
Just one nit re the docs, otherwise looks good
mnaumanali94
left a comment
There was a problem hiding this comment.
Beautiful. Hopefully we can get given here too eventually.
|
Despite it being a de jure breaking change, de facto it is not such since the actual usage is almost non-existent. |
# [@stoplight/spectral-core-v1.10.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-core-v1.9.0...@stoplight/spectral-core-v1.10.0) (2022-01-28) ### Features * **core:** aliases take only array-ish given ([#2033](#2033)) ([263dc20](263dc20))
|
🎉 This PR is included in version @stoplight/spectral-core-v1.10.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
# [@stoplight/spectral-rulesets-v1.4.0](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-rulesets-v1.3.2...@stoplight/spectral-rulesets-v1.4.0) (2022-01-28) ### Features * **core:** aliases take only array-ish given ([#2033](#2033)) ([263dc20](263dc20))
|
🎉 This PR is included in version @stoplight/spectral-rulesets-v1.4.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
a month later this change made it to Studio and SHOCKINGLY it broke styleguides! (of course it did 🙃) @mnaumanali94 making breaking changes and violating semver is a terrible idea. @P0lip trust your gut next time. |
As requested by @mnaumanali94, aliases are arrays-only now.
This is in line with that @marbemac suggested back in the previous PR.
Checklist
Does this PR introduce a breaking change?