Skip to content

fix: bump json-schema-viewer and json-schema-tree version#2481

Merged
brendarearden merged 3 commits intomainfrom
fix/2419-sibling-examples-ref
Dec 15, 2023
Merged

fix: bump json-schema-viewer and json-schema-tree version#2481
brendarearden merged 3 commits intomainfrom
fix/2419-sibling-examples-ref

Conversation

@brendarearden
Copy link
Contributor

@brendarearden brendarearden commented Dec 14, 2023

Elements Default PR Template

In general, make sure you have: (check the boxes to acknowledge you've followed this template)

Other Available PR Templates:

Fixes: #2419

When resolving references in an allOf, if the reference had a description or summary sibling, it was getting overwritten by the description or summary in the referenced object, if the same key existed. Starting in OAS 3.1, description and summary became supported reference siblings.

This PR bumps versions of packages that have been updated to not overwrite description and summary ref siblings for allOf objects to stay inline with OAS 3.1

Image from modified static-html app with the latest version bumps using a modified version of the OAS file provided in the reported issue :
Screenshot 2023-12-14 at 3 35 35 PM

@brendarearden brendarearden requested a review from a team as a code owner December 14, 2023 23:08
@brendarearden brendarearden force-pushed the fix/2419-sibling-examples-ref branch from e3b9ea9 to df9d8bc Compare December 14, 2023 23:09
@netlify
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit e3b9ea9
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/657b8af5c6bf5b00080a56cf
😎 Deploy Preview https://deploy-preview-2481--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit e3b9ea9
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/657b8af5d4bd1d00097e5247
😎 Deploy Preview https://deploy-preview-2481--stoplight-elements-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brendarearden
Copy link
Contributor Author

@netlify
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit bb5e7ae
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements/deploys/657c84d01976890008330225
😎 Deploy Preview https://deploy-preview-2481--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit bb5e7ae
🔍 Latest deploy log https://app.netlify.com/sites/stoplight-elements-demo/deploys/657c84d0c6fc250008270a20
😎 Deploy Preview https://deploy-preview-2481--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brendarearden brendarearden requested review from a team and removed request for a team December 14, 2023 23:20
@mallachari
Copy link

Don't you want to release that package too?

@brendarearden brendarearden force-pushed the fix/2419-sibling-examples-ref branch from d300655 to bb5e7ae Compare December 15, 2023 16:54
@mallachari
Copy link

Release looks good too!

@brendarearden brendarearden merged commit 04aee60 into main Dec 15, 2023
@brendarearden brendarearden deleted the fix/2419-sibling-examples-ref branch December 15, 2023 17:12
AhalyaPai pushed a commit to jpmorganchase/elemental that referenced this pull request Feb 14, 2025
…o#2481)

* fix: bump json-schema-viewer and json-schema-tree version

* chore: release

---------

Co-authored-by: Chelsea Hohmann <33431856+chohmann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Referring object tamper other objects through referenced one

3 participants