JsonObject.similar() number entry check bug fix#613
Merged
Conversation
Owner
Author
|
What problem does this code solve? Risks Changes to the API? Will this require a new release? Should the documentation be updated? Does it break the unit tests? Was any code refactored in this commit? Review status Starting 3 day comment window |
johnjaylward
suggested changes
Jul 18, 2021
Contributor
johnjaylward
left a comment
There was a problem hiding this comment.
Please also correct the implementation in JSONArray
Contributor
|
Also, due to the nature of the bug fix, this probably should get a new release. |
Owner
Author
|
Forgot to check JsonArray, thanks for the heads-up @johnjaylward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#611 reported that similar returns too soon on success when a Number entry type is checked. Fixed by returning only if the Number check fails. Added unit test to exercise the new code.