add configuration for xsi:nil="true" conversion to null#467
Merged
stleary merged 1 commit intostleary:masterfrom Apr 22, 2019
Merged
Conversation
a563fae to
1773717
Compare
1773717 to
d5b2785
Compare
Owner
|
HI @meiskalt7. Thanks for submitting this PR, it is appreciated, and sorry for not responding sooner. Looks like no one on the team has a strong opinion regarding this change. Your change does not break unit tests, so that is good, but you will need to add additional unit tests if you want to proceed. Please refer to the FAQ. |
Contributor
Author
|
Thanks for your answer. I will add tests for this changes ASAP. |
Contributor
Author
|
I added test for this pull request |
Owner
|
Approved. Starting 3 day comment window. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello :-)
I add configuration for xsi:nil="true" conversion to null. In JSON spec null should be represented like
{ key: null }
link: https://stackoverflow.com/questions/21120999/representing-null-in-json
Please check it and merge, cause it is necessary for many dependent projects.
What problem does this code solve?
Representation of null in accordance with JSON spec
Risks
Low
Changes to the API?
No, only addition new constructor for XMLParserConfiguration
Will this require a new release?
Yes.
Should the documentation be updated?
Yes. Javadoc already updated.
Does it break the unit tests?
No
Was any code refactored in this commit?
Yes, changes were made to the number parsing methods for XML and added new configuration
(no changes in public methods)
Backward compatibility
Yes
Review status
APPROVED