Skip to content

docs: fix invalid transport_socket value (#9403)#114

Merged
sthagen merged 1 commit intosthagen:masterfrom
envoyproxy:master
Dec 19, 2019
Merged

docs: fix invalid transport_socket value (#9403)#114
sthagen merged 1 commit intosthagen:masterfrom
envoyproxy:master

Conversation

@sthagen
Copy link
Copy Markdown
Owner

@sthagen sthagen commented Dec 19, 2019

Signed-off-by: Derek Argueta dereka@pinterest.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: Derek Argueta <dereka@pinterest.com>
@sthagen sthagen merged commit 6677415 into sthagen:master Dec 19, 2019
sthagen pushed a commit that referenced this pull request Mar 5, 2020
Previously, the update callback was called only when the secret
was received for the first time or when its value changed.

This meant that if the same secret (e.g. trusted CA) was used in
multiple resources, then resources using it but configured after
the secret was already received, remained unconfigured until the
secret's value changed.

The missing callback should have resulted in transport factories
stuck in the "not ready" state, however, because of an incorrect
code, the available secret was processed like inlined validation
context, and only rules from the "secret" part of the validation
context were applied, leading to a complete bypass of rules from
the "default" part.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Co-authored-by: Oliver Liu <yonggangl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants