Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #471 +/- ##
========================================
Coverage 92.14% 92.15%
========================================
Files 86 86
Lines 13834 13734 -100
========================================
- Hits 12747 12656 -91
+ Misses 1087 1078 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Thanks Aidan - that all looks good but I found a few places that may also need an update:
./tests/test_fparser_module.py: # Use backport package for python <3.8
./tests/test_fparser_module.py: # Can't check the actual value as some versions of Python3 return
./one/tests/test_select.py:# stdout before the pytest framework can intercept it. In python < 3
./one/tests/test_scripts.py: # Can't check the actual value as some versions of Python3 return
./common/splitline.py: Note: Python 3.9 comes with a thread-safe and more efficient cache as it
./__init__.py: # Use backport package for python <3.8
Please could you take a look.
|
@arporter I think two of those I'd already resolved (but maybe afte ryou started the review) - I fixed 3 of them and created an issue and TODO about the remaining one. |
arporter
left a comment
There was a problem hiding this comment.
All good now, thanks.
I'll proceed to merge.
|
@LonelyCat124 @arporter python3.9 is not EOL and system used by NG-Arch, like Archer2 have it as default, so I suggest adding back 3.9 in one of your open PRs. |
@arporter @sergisiso @hiker Small change to bump python version.