#443 Support flag that triggers fparser to read code in OpenMP conditional sentinels#444
#443 Support flag that triggers fparser to read code in OpenMP conditional sentinels#444
Conversation
…ional sentinels.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 91.99% 92.07% +0.08%
==========================================
Files 85 85
Lines 13678 13825 +147
==========================================
+ Hits 12583 12730 +147
Misses 1095 1095 ☔ View full report in Codecov by Sentry. |
arporter
left a comment
There was a problem hiding this comment.
Looks good Joerg, thanks for adding this.
Mostly small things/renaming/extending tests.
Please could you also update the documentation (I've indicated a suitable location somewhere in the review).
…hout optional &.
|
Ready for next review. |
|
Hi @hiker, github isn't showing any commits since the last review? |
|
Dang, yes, I missed that you updated this branch, so my push didn't go through, and I didn't notice. Now something should be there :) |
arporter
left a comment
There was a problem hiding this comment.
Almost there now. Just a few minor things and some weird cases where black has changed a "..." + "..." into "..." "...".
Update doc builds fine.
I've checked on CodeCov and all is well, even if that's not being reported here.
…ng concatenations warnings.
|
Ready for next review. |
arporter
left a comment
There was a problem hiding this comment.
All good now, thanks for those changes.
Will proceed to merge.
Fixed #443, and is important for FAB to detect dependencies in omp sentinels.
The implementation is (unfortunately) on two different levels:
!$omp(since a '&' and esp. spaces around that are all optional), so it's handled on higher up when combining multiple lines.Moving the fixed format handling up (to the level where the free format is handled) seems to be more difficult, since free format is handled in many different ways when combining lines (strict format, fixed, f77) - so I opted for the two different levels.
I can confirm that this with changes fab now (when supplying the required optional flag) detects dependencies in conditional omp sentinels.