Skip to content

440 add split file example#442

Merged
arporter merged 14 commits intomasterfrom
440_add_split_file_example
Apr 9, 2024
Merged

440 add split file example#442
arporter merged 14 commits intomasterfrom
440_add_split_file_example

Conversation

@hiker
Copy link
Collaborator

@hiker hiker commented Jan 24, 2024

Ready for review. I have used this script to divide a driver back into the original files, and found it very convenient, esp. the fact that it creates a Makefile with dependencies etc.

@codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c3808d) 91.96% compared to head (5df7c68) 91.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #442   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files          85       85           
  Lines       13644    13644           
=======================================
  Hits        12548    12548           
  Misses       1096     1096           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (a9ea1e9) to head (5df7c68).

❗ Current head 5df7c68 differs from pull request most recent head 55f166d. Consider uploading reports for the commit 55f166d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   91.99%   91.96%   -0.03%     
==========================================
  Files          85       85              
  Lines       13678    13644      -34     
==========================================
- Hits        12583    12548      -35     
- Misses       1095     1096       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition Joerg, it's nice. I'm happy with everything although it made me realise that we still need to do #279 (add a CI workflow to run the examples). We could also do with adding a section on the examples to the documentation. However, neither of those things are part of this PR.

@arporter arporter added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Apr 9, 2024
@arporter arporter merged commit 45631e2 into master Apr 9, 2024
@arporter arporter deleted the 440_add_split_file_example branch April 9, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for merge PR is waiting on final CI checks before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants