(Closes #426) Add convert argument to open().#435
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 91.99% 91.96% -0.04%
==========================================
Files 85 85
Lines 13681 13641 -40
==========================================
- Hits 12586 12545 -41
- Misses 1095 1096 +1 ☔ View full report in Codecov by Sentry. |
|
In the interests of speed (of implementation) I haven't added full testing of the OPEN statement here. |
rupertford
left a comment
There was a problem hiding this comment.
Some additional tests, refactoring and making the extension optional are required - please see inline comments.
|
Ready for another look now. Ran across #432 while trying to check the documentation. Happily that's a separate issue though :-) |
|
Taking this back as I've discovered it doesn't work if one requests a F2008 parser instead of F2003! |
|
This has got a bit bigger as, on looking at the Fortran2008 implementation of Open (which I missed first time around), I realised that there was a lot of code duplication that could be factored out. I also slightly refactored the way that we handle the list of supported extensions (we now have a method that returns the list rather than just a module-scope variable containing a list). This makes testing a bit cleaner as monkeypatch can be used more easily. Ready for another look now. |
sergisiso
left a comment
There was a problem hiding this comment.
@arporter Again, I gave a quick read to this PR since this was already reviewed once to check that I agree with the general solution and that the previously raised comments from @rupertford are now all resolved. This is ready to merge.
No description provided.